Use GetParents() in FireSppressedNotifications()

yhabteab · yhabteab · commit 0873153537be · 2025-02-10T11:40:33.000+01:00
It's way efficient than accessing them through the dependency objects,
plus we won't have any duplicates.
diff --git a/lib/icinga/checkable-notification.cpp b/lib/icinga/checkable-notification.cpp
@@ -167,8 +167,7 @@ void Checkable::FireSuppressedNotifications()
 				}
 			}
 
-			for (auto& dep : GetDependencies()) {
-				auto parent (dep->GetParent());
+			for (auto& parent : GetParents()) {
 				ObjectLock oLock (parent);
 
 				if (!parent->GetProblem() && parent->GetLastStateChange() >= threshold) {

Original file line number	Diff line number	Diff line change
`@@ -167,8 +167,7 @@ void Checkable::FireSuppressedNotifications()`
`167`	`167`	`}`
`168`	`168`	`}`
`169`	`169`
`170`		`- for (auto& dep : GetDependencies()) {`
`171`		`- auto parent (dep->GetParent());`
	`170`	`+ for (auto& parent : GetParents()) {`
`172`	`171`	`ObjectLock oLock (parent);`
`173`	`172`
`174`	`173`	`if (!parent->GetProblem() && parent->GetLastStateChange() >= threshold) {`