Skip to content

Conversation

@Al2Klimov
Copy link
Member

to query them at runtime lock-freely.

@Al2Klimov Al2Klimov added enhancement New feature or request core/quality Improve code, libraries, algorithms, inline docs labels Mar 21, 2025
@cla-bot cla-bot bot added the cla/signed label Mar 21, 2025
@Al2Klimov Al2Klimov requested a review from julianbrost March 28, 2025 11:12
@julianbrost
Copy link
Member

@Al2Klimov I'd suggest you to answer the questions in the previous review first before requesting another review.

@Al2Klimov
Copy link
Member Author

Done.

Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're touching all the classes anyway, please remove the first template parameter from Registry, it's just useless and isn't requried by that class to function correctly.

EDIT: Also, please rebase the PR, so that the GHAs run successfully.

Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me now, although I'm confused with the verboseness of the commits.

@Al2Klimov Al2Klimov added this to the 2.16.0 milestone Jan 26, 2026
@Al2Klimov Al2Klimov enabled auto-merge January 26, 2026 14:35
@Al2Klimov Al2Klimov merged commit 9bffe06 into master Jan 26, 2026
28 checks passed
@Al2Klimov Al2Klimov deleted the Registry-Freeze branch January 26, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed core/quality Improve code, libraries, algorithms, inline docs enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants