-
Notifications
You must be signed in to change notification settings - Fork 596
Freeze registries at startup, when everything has been registered #10388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Al2Klimov I'd suggest you to answer the questions in the previous review first before requesting another review. |
5407de3 to
e90a62a
Compare
e90a62a to
e4bfbf2
Compare
in derived classes and inline them, as side effect, to speed up calls.
e4bfbf2 to
cba30e7
Compare
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're touching all the classes anyway, please remove the first template parameter from Registry, it's just useless and isn't requried by that class to function correctly.
EDIT: Also, please rebase the PR, so that the GHAs run successfully.
yhabteab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me now, although I'm confused with the verboseness of the commits.
to query them at runtime lock-freely.