docs: Icinga DB Setup for every Distribution#10481
Conversation
Al2Klimov
left a comment
There was a problem hiding this comment.
Indeed, https://icinga.com/docs/icinga-db/latest/doc/02-Installation/openSUSE/ is a thing now and you seem to have undisabled the correct section. But the latter doesn't even contain "openSUSE", in contrast to other OS.
@Al2Klimov: Could you please rephrase your comment? Unfortunately, I failed to understand your objection. I have just build the docs on this PR locally and compared the installation sections for each distribution. There is one diff: The "Set up Icinga DB" section is now available for openSUSE, as intended. |
|
Ok and how does the section look like now for openSUSE? |
Within the GNU/Linux distribution specific installation guides, the "Set up Icinga DB" section was only excluded for openSUSE. However, since there is an openSUSE installation guide within Icinga DB[^0], this is not consistent. Thus, the if-guard was removed, resulting in this section being available for each distribution. Windows is already excluded through an if-guard above. Some cases for Fedora were missing, which were also added. [^0]: https://icinga.com/docs/icinga-db/latest/doc/02-Installation/openSUSE/
7ef69b7 to
950c801
Compare
Exactly like for every other distribution. However, thanks to your Socratic questioning I realized cases for openSUSE and also Fedora were missing, which I have now added. Assuming you were aiming in this direction. Otherwise, please formulate your specific problem with the state of this PR. |
|
|
||
| <!-- {% if sles or opensuse %} --> | ||
| <!-- {% if not icingaDocs %} --> | ||
| ##### SLES / openSUSE |
There was a problem hiding this comment.
While we're on combining multiple OS in one section,
There was a problem hiding this comment.
We are already using common "SLES / openSUSE" sections at other places. I am just mimicking current behavior.
icinga2/doc/02-installation.md
Lines 223 to 230 in c2ca7d1
| ##### Fedora | ||
| <!-- {% endif %} --> | ||
| ```bash | ||
| dnf install icingadb-redis |
There was a problem hiding this comment.
why not here, too? The command is the same as for RHEL.
There was a problem hiding this comment.
Following my prior comment, at other places Fedora and RHEL are separated. Thus, I am following this pattern here as well.
icinga2/doc/02-installation.md
Lines 202 to 221 in c2ca7d1

Within the GNU/Linux distribution specific installation guides, the "Set up Icinga DB" section was only excluded for openSUSE. However, since there is an openSUSE installation guide within Icinga DB1, this is not consistent. Thus, the if-guard was removed, resulting in this section being available for each distribution. Windows is already excluded through an if-guard above.
Some cases for Fedora were missing, which were also added.
Footnotes
https://icinga.com/docs/icinga-db/latest/doc/02-Installation/openSUSE/ ↩