Code quality #9666
Closed
Code quality #9666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
approved these changes
Feb 14, 2023
julianbrost
requested changes
Mar 10, 2023
Member
julianbrost
left a comment
julianbrost
left a comment
There was a problem hiding this comment.
(I haven't looked into the other changes in detail, just the one where I know there is a problem.)
Comment on lines
111
to
118
| for (int i = 0; i < envc; i++) { | ||
| if (strncmp(environ[i], lcnumeric, strlen(lcnumeric)) == 0) { | ||
| if (strcmp(environ[i], lcnumeric) == 0) { | ||
| continue; | ||
| } | ||
|
|
||
| if (strncmp(environ[i], notifySocket, strlen(notifySocket)) == 0) { | ||
| if (strcmp(environ[i], notifySocket) == 0) { | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
That's actually not just a redundant overflow protection but is actually implementing a prefix check here. But that's totally not obvious here, I also got this wrong first. So changing the code to make this more obvious would actually be a quality improvement.
Member
There was a problem hiding this comment.
Al2Klimov
requested changes
Jan 26, 2026
Comment on lines
111
to
118
| for (int i = 0; i < envc; i++) { | ||
| if (strncmp(environ[i], lcnumeric, strlen(lcnumeric)) == 0) { | ||
| if (strcmp(environ[i], lcnumeric) == 0) { | ||
| continue; | ||
| } | ||
|
|
||
| if (strncmp(environ[i], notifySocket, strlen(notifySocket)) == 0) { | ||
| if (strcmp(environ[i], notifySocket) == 0) { | ||
| continue; | ||
| } |
Al2Klimov
reviewed
Jan 26, 2026
Member
Author
|
All the changes from this PR can be found in #9502, so there's no need for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.