Skip to content

Only include requested columns in CSV/JSON exports when using ?columns=… #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilmerg merged 9 commits into from
Nov 19, 2025
Merged

Only include requested columns in CSV/JSON exports when using ?columns=… #1301

nilmerg merged 9 commits into from
Nov 19, 2025

Conversation

@BastianLedererIcinga
Copy link
Contributor

@BastianLedererIcinga BastianLedererIcinga commented Nov 13, 2025 •
edited
Loading

resolves: #1011

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Nov 13, 2025
@nilmerg nilmerg requested review from sukhwinder33445 and removed request for sukhwinder33445 November 13, 2025 11:15
nilmerg
nilmerg requested changes Nov 17, 2025
View reviewed changes
@nilmerg nilmerg added this to the 1.3.0 milestone Nov 17, 2025
@nilmerg nilmerg added affects-upgrades The change requires migration or user awareness area/export Affects exports to other formats labels Nov 17, 2025
@BastianLedererIcinga BastianLedererIcinga force-pushed the enhancement/filter-columns-csv-json branch from 6d13549 to e8f9955 Compare November 18, 2025 08:53
@BastianLedererIcinga
Copy link
Contributor Author

BastianLedererIcinga commented Nov 18, 2025

I made the change to CsvResultSetUtils::stream, because it previously added the CSV-header not only at the beginning of the file, but repeated printing it after every 1000 lines.

nilmerg
nilmerg requested changes Nov 18, 2025
View reviewed changes
nilmerg
nilmerg requested changes Nov 18, 2025
View reviewed changes
nilmerg
nilmerg requested changes Nov 19, 2025
View reviewed changes
@nilmerg
Copy link
Member

nilmerg commented Nov 19, 2025

and please rebase

@BastianLedererIcinga BastianLedererIcinga force-pushed the enhancement/filter-columns-csv-json branch from a828354 to 80ea714 Compare November 19, 2025 08:17
nilmerg
nilmerg requested changes Nov 19, 2025
View reviewed changes
@nilmerg nilmerg changed the title Enhancement/filter columns csv json Only include requested columns in CSV/JSON exports when using ?columns=… Nov 19, 2025
@nilmerg nilmerg merged commit 3c130b7 into main Nov 19, 2025
10 checks passed
@nilmerg nilmerg deleted the enhancement/filter-columns-csv-json branch November 19, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@BastianLedererIcinga BastianLedererIcinga

Labels

affects-upgrades The change requires migration or user awareness area/export Affects exports to other formats cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Support ?columns also for CSV and JSON exports

3 participants

@BastianLedererIcinga @nilmerg