Auth: Merge variable denylists and protections from multiple roles#1302
Merged
Auth: Merge variable denylists and protections from multiple roles#1302
Conversation
nilmerg
added
affects-upgrades
nilmerg
force-pushed
the
change-variable-restrictions
branch
from
22e1aef to
c3227b5
Compare
lippserd
approved these changes
Nov 18, 2025
Member
lippserd
left a comment
lippserd
left a comment
There was a problem hiding this comment.
Roughly tested several roles mixing variables with denylist and protect with and without placeholders, as well as restrictions using these variables. Everything worked as expected. And you were right, I was mistaken about the functionality we introduced in the security release.
BastianLedererIcinga
approved these changes
Nov 19, 2025
Contributor
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
Tried mixing roles with different denied and protected vars, including inherited roles. Worked as described in the docs in every case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.