GitHub Actions: Use new PHP workflow

.github/workflows/php.yml

@@ -1,42 +1,13 @@
-name: PHP Tests
+name: CI
 
 on:
   push:
     branches:
       - main
-      - release/*
+      - support/*
   pull_request:
-    branches:
-      - main
 
 jobs:
-  lint:
-    name: Static analysis for php ${{ matrix.php }} on ${{ matrix.os }}
-    runs-on: ${{ matrix.os }}
-
-    strategy:
-      fail-fast: false
-      matrix:
-        php: ['8.2', '8.3', '8.4']
-        os: ['ubuntu-latest']
-
-    steps:
-      - name: Checkout code base
-        uses: actions/checkout@v4
-
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: ${{ matrix.php }}
-          tools: phpcs
-
-      - name: Setup dependencies
-        run: composer require -n --no-progress overtrue/phplint
-
-      - name: PHP Lint
-        if: ${{ ! cancelled() }}
-        run: ./vendor/bin/phplint -n --exclude={^vendor/.*} -- .
-
-      - name: PHP CodeSniffer
-        if: ${{ ! cancelled() }}
-        run: phpcs
+  php:
+    name: PHP
+    uses: Icinga/github-actions/.github/workflows/php.yml@main

library/Pdfexport/HeadlessChrome.php

@@ -1,3 +1,3 @@
 <?php
 
 /* Icinga PDF Export | (c) 2018 Icinga GmbH | GPLv2 */
@@ -27,13 +27,13 @@
      *
      * First matching group is the used port and the second one the browser id.
      */
-    const DEBUG_ADDR_PATTERN = '/DevTools listening on ws:\/\/((?>\d+\.?){4}:\d+)\/devtools\/browser\/([\w-]+)/';
+    public const DEBUG_ADDR_PATTERN = '/DevTools listening on ws:\/\/((?>\d+\.?){4}:\d+)\/devtools\/browser\/([\w-]+)/';
 
     /** @var string */
-    const WAIT_FOR_NETWORK = 'wait-for-network';
+    public const WAIT_FOR_NETWORK = 'wait-for-network';
 
     /** @var string Javascript Promise to wait for layout initialization */
-    const WAIT_FOR_LAYOUT = <<<JS
+    public const WAIT_FOR_LAYOUT = <<<JS
 new Promise((fulfill, reject) => {
     let timeoutId = setTimeout(() => reject('fail'), 10000);
 
@@ -191,7 +191,7 @@
 
         foreach ($arguments as $name => $value) {
             if ($value !== null) {
                 $value = escapeshellarg($value);
 
                 if (! is_int($name)) {
                     if (substr($name, -1) === '=') {
@@ -254,9 +254,9 @@
             switch (true) {
                 case $this->remote !== null:
                     try {
                         $result = $this->jsonVersion($this->remote[0], $this->remote[1]);
                         if (is_array($result)) {
                             $parts = explode('/', $result['webSocketDebuggerUrl']);
                             $pdf = $this->printToPDF(
                                 join(':', $this->remote),
                                 end($parts),
@@ -333,7 +333,7 @@
                     $chrome->stderr->on('data', function ($chunk) use ($chrome, $deferred, $killer) {
                         Logger::debug('Caught browser output: %s', $chunk);
 
                         if (preg_match(self::DEBUG_ADDR_PATTERN, trim($chunk), $matches)) {
                             Loop::cancelTimer($killer);
 
                             try {
@@ -429,7 +429,7 @@
 
     private function printToPDF($socket, $browserId, array $parameters)
     {
         $browser = new Client(sprintf('ws://%s/devtools/browser/%s', $socket, $browserId));
 
         // Open new tab, get its id
         $result = $this->communicate($browser, 'Target.createTarget', [
@@ -519,7 +519,7 @@
             $parameters,
             ['transferMode' => 'ReturnAsBase64', 'printBackground' => true]
         ));
-        if (isset($result['data']) && !empty($result['data'])) {
+        if (! empty($result['data'])) {
             $pdf = base64_decode($result['data']);
         } else {
             throw new Exception('Expected base64 data. Got instead: ' . json_encode($result));

library/Pdfexport/PrintableHtmlDocument.php

@@ -17,7 +17,7 @@
 class PrintableHtmlDocument extends BaseHtmlElement
 {
     /** @var string */
-    const DEFAULT_HEADER_FOOTER_STYLE = <<<'CSS'
+    public const DEFAULT_HEADER_FOOTER_STYLE = <<<'CSS'
 @font-face {
   font-family: "Helvetica Neue", "Helvetica", "Arial", sans-serif;
 }