Merged
Conversation
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
3 times, most recently
from
f24ce91 to
ae222f3
Compare
Member
|
I'd rather like to see a no-JS approach |
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
5 times, most recently
from
5045212 to
3c10f14
Compare
Contributor
Author
|
Unlike discussed, I would use the parent name instead of label to avoid displaying state badges. Using label: Using name: |
nilmerg
requested changes
Apr 28, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
When not collapsed, the first entry has none or a narrower gap at the top.
Previous
After
The height of the new element is not the same as the one in the sidebar:
library/Icinga/Web/Navigation/Renderer/RecursiveMenuNavigationRenderer.php
Outdated
Show resolved
Hide resolved
library/Icinga/Web/Navigation/Renderer/RecursiveMenuNavigationRenderer.php
Outdated
Show resolved
Hide resolved
library/Icinga/Web/Navigation/Renderer/RecursiveMenuNavigationRenderer.php
Outdated
Show resolved
Hide resolved
library/Icinga/Web/Navigation/Renderer/RecursiveMenuNavigationRenderer.php
Outdated
Show resolved
Hide resolved
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
5 times, most recently
from
e40bca5 to
eb9dc7e
Compare
nilmerg
requested changes
Apr 29, 2025
library/Icinga/Web/Navigation/Renderer/RecursiveMenuNavigationRenderer.php
Outdated
Show resolved
Hide resolved
library/Icinga/Web/Navigation/Renderer/RecursiveMenuNavigationRenderer.php
Outdated
Show resolved
Hide resolved
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
from
eb9dc7e to
c68c8bd
Compare
nilmerg
requested changes
Apr 30, 2025
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
from
c68c8bd to
e50968d
Compare
nilmerg
force-pushed
the
fix/menu-caret-positioning
branch
from
b71c274 to
1467117
Compare
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
2 times, most recently
from
8cc031c to
ec75bab
Compare
nilmerg
force-pushed
the
fix/menu-caret-positioning
branch
from
1467117 to
6100281
Compare
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
from
ec75bab to
05487b2
Compare
nilmerg
previously approved these changes
Apr 30, 2025
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
from
05487b2 to
68999d6
Compare
jrauh01
force-pushed
the
feature/navigation-flyout-label
branch
from
68999d6 to
233b70f
Compare
nilmerg
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a title to the navigation level-2 flyouts. The title is only displayed if the sidebar is collapsed.
Closes #4968