Closed
Conversation
CompatController::createSortControl(): - Set Default before assembling to set the correct value for the sort dropdown. - Throw error if 3rd param is given but is not present in $columns SortControl::apply(): - Remove unused param and code.
sukhwinder33445
force-pushed
the
fix/sortControl
branch
from
ee5ece1 to
17675cc
Compare
Member
|
please add a test |
sukhwinder33445
force-pushed
the
fix/sortControl
branch
from
135855c to
f20deae
Compare
sukhwinder33445
force-pushed
the
fix/sortControl
branch
from
f20deae to
bca6fa5
Compare
Member
|
Obsoleted by #260 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #242