A ResourceOpts is always to added to callback execution #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by Resource.parse Fixes errors like: ERROR pyff.resource Failed handling resource: MDServiceListParser.parse.<locals>._update_entities() takes 1 positional argument but 2 were given
johanlundberg
approved these changes
Mar 27, 2025
Without the deep copy all opts were added to the origin. E.g causing Lambas to be run on each "entity" instead of just the selected child.
Contributor
Author
|
Big shout out to @johanlundberg and @mikaelfrykholm for debugging the last commit. |
…ervers keep the formatting sane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by Resource.parse
Fixes errors like:
ERROR pyff.resource Failed handling resource:
MDServiceListParser.parse.._update_entities() takes 1 positional argument but 2 were given