Merge pull request #539 from cmurphy/fix-exception

Raise ValueError for invalid attribute type

Author: c00kiemon5ter

src/saml2/saml.py

@@ -224,7 +224,7 @@ def set_text(self, val, base64encode=False):
                         elif typ == "xs:base64Binary":
                             pass
                         else:
-                            ValueError("Type and value doesn't match")
+                            raise ValueError("Type and value doesn't match")
             elif isinstance(val, bool):
                 if val:
                     val = "true"

tests/test_02_saml.py

@@ -243,6 +243,10 @@ def test_set_text(self):
         av.set_text(None)
         assert av.text == ""
 
+        av = AttributeValue()
+        av.set_type('invalid')
+        raises(ValueError, "av.set_text('free text')")
+
     def test_make_vals_div(self):
         foo = saml2.make_vals(666, AttributeValue, part=True)
         assert foo.text == "666"