Skip to content

wkdev-update: Do not pass --exit-when-done to wkdev-create #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wkdev-update: Do not pass --exit-when-done to wkdev-create #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion scripts/host-only/wkdev-update
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,15 @@ update_containers_using_image() {

local recreate_arguments=()
recreate_arguments+=("--home" "$(get_podman_container_home_directory_on_host "${container_name}")")
recreate_arguments+=($(get_podman_container_init_arguments "${container_name}"))
local init_arguments=($(get_podman_container_init_arguments "${container_name}"))
for arg in "${init_arguments[@]}"; do
# wkdev-create --attach passes the --exit-when-done option to .wkdev-init so that
# podman start --attach doesn't hang forever.
# --exit-when-done is not an option of wkdev-create however, so we need to skip it.
if [[ "${arg}" != "--exit-when-done" ]]; then
recreate_arguments+=("${arg}")
fi
done
outdated_container_data["${container_name}"]=${recreate_arguments[@]}
fi

Expand Down