Skip to content

[minibrowser] Apply system bar insets to main view #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aperezdc merged 1 commit into from
Mar 31, 2025
Merged

[minibrowser] Apply system bar insets to main view #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ kotlin = "2.1.0"
vanniktech = "0.30.0"
androidx-navigation-safeargs = "2.8.5"

androidx-activity = "1.10.1"
androidx-annotation = "1.9.1"
androidx-test-runner = "1.6.2"
androidx-test-rules = "1.6.1"
Expand All @@ -36,6 +37,7 @@ vanniktech-maven-publish = { id = "com.vanniktech.maven.publish", version.ref =
androidx-navigation-safeargs = { id = "androidx.navigation.safeargs", version.ref = "androidx-navigation-safeargs" }

[libraries]
androidx-activity = { group = "androidx.activity", name = "activity", version.ref = "androidx-activity" }
androidx-annotation = { group = "androidx.annotation", name = "annotation", version.ref = "androidx-annotation" }
androidx-test-runner = { group = "androidx.test", name = "runner", version.ref = "androidx-test-runner" }
androidx-test-rules = { group = "androidx.test", name = "rules", version.ref = "androidx-test-rules" }
Expand Down
9 changes: 9 additions & 0 deletions tools/minibrowser/src/main/java/org/wpewebkit/tools/minibrowser/BrowserFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ import android.view.*
import android.view.inputmethod.EditorInfo
import android.view.inputmethod.InputMethodManager
import android.widget.FrameLayout
import androidx.core.view.ViewCompat
import androidx.core.view.WindowInsetsCompat
import androidx.core.view.updatePadding
import androidx.fragment.app.Fragment
import androidx.fragment.app.activityViewModels
import androidx.navigation.fragment.findNavController
Expand Down Expand Up @@ -97,6 +100,12 @@ class BrowserFragment : Fragment(R.layout.fragment_browser) {
Log.i(TAG, "onViewCreated")
super.onViewCreated(view, savedInstanceState)

ViewCompat.setOnApplyWindowInsetsListener(binding.main) { v, insets ->
val systemBars = insets.getInsets(WindowInsetsCompat.Type.systemBars())
v.updatePadding(systemBars.left, systemBars.top, systemBars.right, systemBars.bottom)
WindowInsetsCompat.CONSUMED
}

val currentState = browserViewModel.browserState.value
currentState.selectedTabId?.let { selectedTabId ->
val tab = browserViewModel.findTab(selectedTabId)
Expand Down
2 changes: 2 additions & 0 deletions tools/minibrowser/src/main/java/org/wpewebkit/tools/minibrowser/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ package org.wpewebkit.tools.minibrowser
import android.content.res.Configuration
import android.os.Bundle
import android.util.Log
import androidx.activity.enableEdgeToEdge
import androidx.appcompat.app.AppCompatActivity
import androidx.navigation.fragment.NavHostFragment
import org.wpewebkit.tools.minibrowser.databinding.ActivityMainBinding
Expand All @@ -44,6 +45,7 @@ class MainActivity : AppCompatActivity(R.layout.activity_main) {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Log.d(TAG, "onCreate")
enableEdgeToEdge();
binding = ActivityMainBinding.inflate(layoutInflater)
}

Expand Down