Skip to content

move python notebooks out of java source#17

Merged
y0shi merged 1 commit intodevelopmentfrom
chore/move-ml-notebooks
Feb 10, 2026
Merged

move python notebooks out of java source#17
y0shi merged 1 commit intodevelopmentfrom
chore/move-ml-notebooks

Conversation

@y0shi
Copy link
Member

@y0shi y0shi commented Feb 10, 2026

No description provided.

@github-actions
Copy link

AI Code Review

Hey team! 👋 Thanks for submitting this pull request!

Summary

This PR looks great! Moving Python notebooks out of the src/main/java source directory is an excellent step for improving our project's organization and clarity.

Positive Highlights

  • Improved Project Structure: This change significantly improves the overall organization of our repository by separating different language sources. It makes it clearer what is Java robot code and what are auxiliary scripts or training materials.
  • Clearer Build Process: By moving these files, we help ensure our Java build process focuses solely on Java code, preventing potential conflicts or confusion for tools like Gradle or VS Code.

Suggestions

Code Quality (Organization)

  • Dedicated Research/Vision Directory: It looks like you've moved the notebook into src/main/python/vision/model-training. This is a fantastic structure! Continuing to organize all vision-related research, training, and Python scripts within a dedicated src/main/python/vision (or similar) hierarchy will keep our project very tidy. This makes it easy for others to find and understand where different parts of our robot's intelligence are developed.

Questions

  • Just to confirm, was this notebook previously located within a directory typically reserved for Java source code (e.g., src/main/java)? The title implies this, and the move to src/main/python is definitely the right approach!

Keep up the fantastic work on keeping our codebase clean and organized! This kind of attention to detail makes a big difference for the whole team.


This review was automatically generated by AI. Please use your judgment and feel free to discuss any suggestions!

@github-actions
Copy link

✓ Build successful and code formatting check passed!

@y0shi y0shi merged commit cc4420d into development Feb 10, 2026
2 checks passed
@y0shi y0shi deleted the chore/move-ml-notebooks branch February 21, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant