Make address fields nullable, improve phone regex to support dashes #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddidgdimitrov-infragistics
changed the title
ddidgdimitrov-infragistics
force-pushed
the
dgdimitrov/make-address-fields-nullable
branch
from
62d3c93 to
551ee27
Compare
deyvidnenchev
approved these changes
Aug 27, 2025
Contributor
|
@hanastasov @ddidgdimitrov-infragistics lets leave at least one nested prop in order to cover this scenario. |
Contributor
|
Sorry Zdravko I merged and then I saw the comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made all address fields nullable in the Dto object.
Also all field are made nullable in the Db object, as EF is throwing an exception if we try to save null in the DB.
Phone number regex to support dashes and phones starting with 0