refactor(migrations): igNamedImportFilter type guard and cleanup

Author: damyanpetev

projects/igniteui-angular/migrations/common/tsUtils.ts

@@ -97,13 +97,13 @@ export const getImportModulePositions = (sourceText: string, startsWith: string)
     return positions;
 };
 
-/** Filters out statements to named imports (e.g. `import {x, y}`) from PACKAGE_IMPORT */
-export const namedImportFilter = (statement: ts.Statement) => {
-    if (statement.kind === ts.SyntaxKind.ImportDeclaration &&
-        isIgniteuiImport(((statement as ts.ImportDeclaration).moduleSpecifier as ts.StringLiteral).text)) {
-
-        const clause = (statement as ts.ImportDeclaration).importClause;
-        return clause && clause.namedBindings && clause.namedBindings.kind === ts.SyntaxKind.NamedImports;
+/** Filters out statements to named imports (e.g. `import {x, y}`) from IG_PACKAGE_NAME */
+export const igNamedImportFilter = (
+    statement: ts.Statement,
+): statement is ts.ImportDeclaration & { moduleSpecifier: ts.StringLiteral } & { importClause: { namedBindings: ts.NamedImports } } => {
+    if (ts.isImportDeclaration(statement) && ts.isStringLiteral(statement.moduleSpecifier) && isIgniteuiImport(statement.moduleSpecifier.text)) {
+        const clause = statement.importClause;
+        return clause?.namedBindings && clause.namedBindings.kind === ts.SyntaxKind.NamedImports;
     }
     return false;
 };
@@ -114,14 +114,13 @@ export const getRenamePositions = (sourcePath: string, name: string, service: ts
     const source = service.getProgram().getSourceFile(sourcePath);
     const positions = [];
 
-    // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
-    const imports = source.statements.filter(<(a: ts.Statement) => a is ts.ImportDeclaration>namedImportFilter);
+    const imports = source.statements.filter(igNamedImportFilter);
     if (!imports.length) {
         return positions;
     }
     const elements: ts.NodeArray<ts.ImportSpecifier> =
         imports
-            .map(x => (x.importClause.namedBindings as ts.NamedImports).elements)
+            .map(x => x.importClause.namedBindings.elements)
             .reduce((prev, current) => prev.concat(current) as unknown as ts.NodeArray<ts.ImportSpecifier>);
 
     for (const elem of elements) {

projects/igniteui-angular/migrations/update-17_0_0/index.ts

@@ -8,7 +8,7 @@ import * as ts from 'typescript';
 import { UpdateChanges } from '../common/UpdateChanges';
 // use bare specifier to escape the schematics encapsulation for the dynamic import:
 import { nativeImport } from 'igniteui-angular/migrations/common/import-helper.js';
-import { namedImportFilter } from '../common/tsUtils';
+import { igNamedImportFilter } from '../common/tsUtils';
 import { FileChange, findElementNodes, getAttribute, getSourceOffset, hasAttribute, parseFile } from '../common/util';
 
 const version = '17.0.0';
@@ -95,7 +95,7 @@ export default (): Rule => async (host: Tree, context: SchematicContext) => {
         var fileContent = host.read(filePath).toString();
 
         const source = ts.createSourceFile('', fileContent, ts.ScriptTarget.Latest, true)
-        const igImports = source.statements.filter(<(a: ts.Statement) => a is ts.ImportDeclaration>namedImportFilter);
+        const igImports = source.statements.filter(igNamedImportFilter);
 
         // Find all animations imported from 'igniteui-angular' and delete them.
         for (const igImport of igImports) {

projects/igniteui-angular/migrations/update-21_0_0_import-migration/index.ts

@@ -5,7 +5,7 @@ import type {
     Tree
 } from '@angular-devkit/schematics';
 import * as ts from 'typescript';
-import { IG_PACKAGE_NAME, IG_LICENSED_PACKAGE_NAME, namedImportFilter } from '../common/tsUtils';
+import { IG_PACKAGE_NAME, IG_LICENSED_PACKAGE_NAME, igNamedImportFilter } from '../common/tsUtils';
 
 const version = '21.0.0';
 
@@ -711,22 +711,12 @@ const TYPE_RENAMES = new Map<string, { newName: string, entryPoint: string }>([
 ]);
 
 function migrateImportDeclaration(node: ts.ImportDeclaration, sourceFile: ts.SourceFile): { start: number, end: number, replacement: string } | null {
-    // Use namedImportFilter to check if this is a valid igniteui-angular named import
-    if (!namedImportFilter(node)) {
+    if (!igNamedImportFilter(node)) {
         return null;
     }
 
-    const moduleSpecifier = node.moduleSpecifier as ts.StringLiteral;
-    const importPath = moduleSpecifier.text;
-
-    // Only process base igniteui-angular imports (not already using entry points)
-    if (importPath !== IG_PACKAGE_NAME && importPath !== IG_LICENSED_PACKAGE_NAME) {
-        return null;
-    }
-
-    // namedImportFilter already validates importClause and namedBindings exist with NamedImports type
-    const importClause = node.importClause!;
-    const namedBindings = importClause.namedBindings as ts.NamedImports;
+    const importPath = node.moduleSpecifier.text;
+    const namedBindings = node.importClause.namedBindings;
 
     // Group imports by entry point
     const entryPointGroups = new Map<string, string[]>();
@@ -873,7 +863,7 @@ export default function migrate(): Rule {
 
             const originalContent = content.toString();
 
-            // Quick check if file has base igniteui-angular imports (not using entry point subpaths)
+            // Check if file has base igniteui-angular imports
             if (!originalContent.includes(`from '${IG_PACKAGE_NAME}'`) && !originalContent.includes(`from "${IG_PACKAGE_NAME}"`) &&
                 !originalContent.includes(`from '${IG_LICENSED_PACKAGE_NAME}'`) && !originalContent.includes(`from "${IG_LICENSED_PACKAGE_NAME}"`)) {
                 return;