Merge branch 'master' into mkirova/fix-13583

Author: kdinev

.gitignore

@@ -52,3 +52,6 @@ src/**/*.css.map
 extras/docs/themes/typedoc/bin
 extras/docs/themes/sassdoc/node_modules
 extras/docs/themes/sassdoc/sassdoc/*
+
+# Localization sources
+i18nRepo

CHANGELOG.md

@@ -17,7 +17,17 @@ All notable changes for each version of this project will be documented in this
 - We're working on reducing the library size
     - IgxRadioComponent has been reduced in half
     - IgxSwitchComponent has been reduced in half
+- `IgxCombo`
+    - **Breaking Change** `IComboSelectionChangingEventArgs` properties `newSelection` and `oldSelection` have been renamed to `newValue` and `oldValue` respectively to better reflect their function. Just like Combo's `value`, those will emit either the specified property values or full data items depending on whether `valueKey` is set or not. Automatic migrations are available and will be applied on `ng update`.
+    - `IComboSelectionChangingEventArgs` exposes two new properties `newSelection` and `oldSelection` in place of the old ones that are no longer affected by `valueKey` and consistently emit items from Combo's `data`.
+      
+      Note: In remote data scenarios with `valueKey` set, selected items that are not currently part of the loaded data chunk will be emitted a partial item data object with the `valueKey` property.
+    - **Breaking Change** - `IComboSelectionChangingEventArgs` properties `added` and `removed` now always contain data items, regardless of `valueKey` being set. This aligns them with the updated `newSelection` and `oldSelection` properties, including the same limitation for remote data as described above.
+- `IgxSimpleCombo`
+    - **Breaking Change** - `ISimpleComboSelectionChangingEventArgs` properties `newSelection` and `oldSelection` have been renamed to `newValue` and `oldValue` respectively to better reflect their function. Just like Combo's `value`, those will emit either the specified property value or full data item depending on whether `valueKey` is set or not. Automatic migrations are available and will be applied on `ng update`.
+    - `ISimpleComboSelectionChangingEventArgs` exposes two new properties `newSelection` and `oldSelection` in place of the old ones that are no longer affected by `valueKey` and consistently emit items from Combo's `data`.
 
+      Note: In remote data scenarios with `valueKey` set, selected items that are not currently part of the loaded data chunk will be emitted a partial item data object with the `valueKey` property.
 ## 16.1.4
 ### New Features
 - `Themes`:

gulpfile.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const browserSync = require('browser-sync').create();
 const del = require('del');
 const gulp = require('gulp');
 const process = require('process');
@@ -9,16 +8,10 @@ const argv = require('yargs').argv;
 const sassdoc = require('sassdoc');
 const path = require('path');
 const { series } = require('gulp');
-const { spawnSync } = require('child_process');
 const slash = require('slash');
 
 const DOCS_OUTPUT_PATH = slash(path.join(__dirname, 'dist', 'igniteui-angular', 'docs'));
 
-const TYPEDOC_THEME = {
-    SRC: slash(path.join(__dirname, 'node_modules', 'ig-typedoc-theme', 'dist')),
-    OUTPUT: slash(path.join(DOCS_OUTPUT_PATH, 'typescript'))
-};
-
 module.exports.copyGitHooks = async (cb) => {
 
     if (process.env.AZURE_PIPELINES || process.env.TRAVIS || process.env.CI || !fs.existsSync('.git')) {
@@ -94,115 +87,12 @@ module.exports.copySchematics = (cb) => {
     cb();
 };
 
-const typedocBuildTheme = (cb) => {
-    spawnSync(`typedoc`, [
-        TYPEDOC.PROJECT_PATH,
-        "--tsconfig",
-        path.join(__dirname, "tsconfig.typedoc.json")],
-        { stdio: 'inherit', shell: true });
-    cb();
-};
-typedocBuildTheme.displayName = 'typedoc-build:theme';
-
-const browserReload = (cb) => {
-    browserSync.reload();
-
-    cb();
-};
-
-const typedocServe = (cb) => {
-    const config = {
-        server: {
-            baseDir: TYPEDOC_THEME.OUTPUT
-        },
-        port: 3000
-    }
-
-    browserSync.init(config);
-
-    cb();
-};
-
-function typedocWatchFunc(cb) {
-    gulp.watch([
-        slash(path.join(TYPEDOC_THEME.SRC, 'assets', 'js', 'src', '/**/*.{ts,js}')),
-        slash(path.join(TYPEDOC_THEME.SRC, 'assets', 'css', '/**/*.{scss,sass}')),
-        slash(path.join(TYPEDOC_THEME.SRC, '/**/*.hbs')),
-        slash(path.join(TYPEDOC_THEME.SRC, 'assets', 'images', '/**/*.{png,jpg,gif}')),
-    ], series(typedocBuildTheme, browserReload));
-
-    cb();
-}
-
-
-const TYPEDOC = {
-    EXPORT_JSON_PATH: slash(path.join(DOCS_OUTPUT_PATH, 'typescript-exported')),
-    PROJECT_PATH: slash(path.join(__dirname, 'projects', 'igniteui-angular', 'src', 'public_api.ts')),
-    TEMPLATE_STRINGS_PATH: slash(path.join(__dirname, 'extras', 'template', 'strings', 'shell-strings.json'))
-};
-
-function typedocBuildExportFn(cb) {
-    const childProcess = spawnSync('typedoc', [
-        TYPEDOC.PROJECT_PATH,
-        "--generate-json",
-        TYPEDOC.EXPORT_JSON_PATH,
-        "--tsconfig",
-        path.join(__dirname, "tsconfig.typedoc.json")],
-        { stdio: 'inherit', shell: true });
-    process.exitCode = childProcess.status || 0;
-    cb();
-}
-
-function typedocImportJsonFn(cb) {
-    const childProcess = spawnSync('typedoc', [
-        TYPEDOC.PROJECT_PATH,
-        "--generate-from-json",
-        TYPEDOC.EXPORT_JSON_PATH,
-        "--warns",
-        "--tsconfig",
-        path.join(__dirname, "tsconfig.typedoc.json")],
-        { stdio: 'inherit', shell: true });
-    process.exitCode = childProcess.status || 0;
-    cb();
-}
 
 function createDocsOutputDirFn(cb) {
     !fs.existsSync(DOCS_OUTPUT_PATH) && fs.mkdirSync(DOCS_OUTPUT_PATH);
     cb();
 }
 
-function cleanTypedocOutputDirFn(cb) {
-    del.sync(slash(path.join(DOCS_OUTPUT_PATH, 'typescript')));
-    cb();
-}
-
-function typedocBuildDocsJA(cb) {
-    const childProcess = spawnSync('typedoc', [
-        TYPEDOC.PROJECT_PATH,
-        '--generate-from-json',
-        slash(path.join(__dirname, 'i18nRepo', 'typedoc', 'ja')),
-        '--templateStrings',
-        TYPEDOC.TEMPLATE_STRINGS_PATH,
-        '--warns',
-        '--localize',
-        'jp',
-        "--tsconfig",
-        path.join(__dirname, "tsconfig.typedoc.json")], { stdio: 'inherit', shell: true });
-    process.exitCode = childProcess.status || 0;
-    cb();
-}
-
-function typedocBuildDocsEN(cb) {
-    const childProcess = spawnSync('typedoc', [
-        TYPEDOC.PROJECT_PATH,
-        '--localize',
-        'en',
-        "--tsconfig",
-        path.join(__dirname, "tsconfig.typedoc.json")], { stdio: 'inherit', shell: true });
-    process.exitCode = childProcess.status || 0;
-    cb();
-}
-
 const SASSDOC = {
     PROJECT_PATHS: [
         `${path.join(__dirname, 'projects', 'igniteui-angular', 'src', 'lib', 'core', 'styles')}/**/*.scss`,
@@ -276,29 +166,6 @@ function sassdocBuildEN(cb) {
 
 module.exports.createDocsOutputDir = createDocsOutputDirFn;
 
-/**
- * Typedoc build tasks
- */
-module.exports.exportTypedocJson = typedocBuildExportFn;
-module.exports.cleanTypedocOutputDir = cleanTypedocOutputDirFn;
-module.exports.typedocBuildTheme = typedocBuildTheme;
-module.exports.importTypedocJson = typedocImportJsonFn;
-module.exports.typedocServe = series(
-    typedocBuildTheme,
-    typedocWatchFunc,
-    typedocServe
-);
-module.exports.typedocBuildDocsJA = series(
-    this.createDocsOutputDir,
-    this.cleanTypedocOutputDir,
-    typedocBuildDocsJA
-);
-module.exports.typedocBuildDocsEN = series(
-    this.createDocsOutputDir,
-    this.cleanTypedocOutputDir,
-    typedocBuildDocsEN
-);
-
 /**
  * Sassdoc build tasks
  */