Merge pull request #14339 from IgniteUI/dpetev/combo-filter-options

[Combo] Make  FilteringOptions.caseSensitive optional, revert filterable migration for now

Author: ChronosSF

projects/igniteui-angular/migrations/update-18_0_0/changes/inputs.json

@@ -161,15 +161,6 @@
                 "selector": "igx-pivot-grid",
                 "type": "component"
             }
-        },
-        {
-            "name": "filterable",
-            "replaceWith": "filteringOptions",
-            "valueTransform": "comboFilteringTransform",
-            "owner": {
-                "selector": "igx-combo",
-                "type": "component"
-            }
         }
     ]
 }

projects/igniteui-angular/migrations/update-18_0_0/index.spec.ts

@@ -507,24 +507,4 @@ public onBannerOpened(event: BannerEventArgs) {
                 tree.readContent('/testSrc/appPrefix/component/expansion-test.component.ts')
             ).toEqual(expectedContent);
     });
-
-    it('should replace Combo property `filterable` with `filteringOptions`', async () => {
-        appTree.create(`/testSrc/appPrefix/component/test.component.html`,
-        `
-        <igx-combo [filterable]="false"></igx-combo>
-        <igx-combo filterable="true"></igx-combo>
-        <igx-combo [filterable]="myProp"></igx-combo>
-        `
-        );
-
-        const tree = await schematicRunner.runSchematic(migrationName, { shouldInvokeLS: false }, appTree);
-
-        expect(tree.readContent('/testSrc/appPrefix/component/test.component.html')).toEqual(
-        `
-        <igx-combo [filteringOptions]="{ filterable: false }"></igx-combo>
-        <igx-combo [filteringOptions]="{ filterable: true }"></igx-combo>
-        <igx-combo [filteringOptions]="{ filterable: myProp }"></igx-combo>
-        `
-        );
-    });
 });

projects/igniteui-angular/migrations/update-18_0_0/index.ts

@@ -77,21 +77,6 @@ export default (): Rule => async (host: Tree, context: SchematicContext) => {
         }
     });
 
-    update.addValueTransform('comboFilteringTransform', (args: BoundPropertyObject): void => {
-        args.bindingType = InputPropertyType.EVAL;
-
-        switch (args.value) {
-            case 'true':
-                args.value = '{ filterable: true }';
-                break;
-            case 'false':
-                args.value = '{ filterable: false }';
-                break;
-            default:
-                args.value = `{ filterable: ${args.value} }`;
-        }
-    });
-
     const updateMainCSSFile = (host: Tree, context: SchematicContext): Tree => {
         const angularConfigBuffer = host.read('angular.json');
         if (!angularConfigBuffer) {

projects/igniteui-angular/src/lib/combo/combo.common.ts

@@ -106,7 +106,7 @@ export const enum DataTypes {
 /** The filtering criteria to be applied on data search */
 export interface IComboFilteringOptions {
     /** Defines filtering case-sensitivity */
-    caseSensitive: boolean;
+    caseSensitive?: boolean;
     /** Defines whether filtering is allowed */
     filterable: boolean;
     /** Defines optional key to filter against complex list items. Default to displayKey if provided.*/