Skip to content

fix(pivot-grid): added createRow method for grid based events#15209

Merged
dkamburov merged 18 commits into19.2.xfrom
ttonev/fix-14970-master
Jun 20, 2025
Merged

fix(pivot-grid): added createRow method for grid based events#15209
dkamburov merged 18 commits into19.2.xfrom
ttonev/fix-14970-master

Conversation

@tishko0
Copy link
Contributor

@tishko0 tishko0 commented Jan 7, 2025

Closes #14970

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@tishko0 tishko0 requested a review from dkamburov January 7, 2025 15:57
@tishko0 tishko0 added ❌ status: awaiting-test PRs awaiting manual verification grid: pivot labels Jan 9, 2025
@dkamburov dkamburov self-assigned this Jan 13, 2025
@dkamburov dkamburov requested a review from skrustev January 13, 2025 14:53
@skrustev skrustev self-requested a review February 4, 2025 08:36
@tishko0 tishko0 added 🛠️ status: in-development Issues and PRs with active development on them and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 14, 2025
@tishko0 tishko0 requested a review from skrustev February 19, 2025 10:40
@tishko0 tishko0 added ❌ status: awaiting-test PRs awaiting manual verification and removed 🛠️ status: in-development Issues and PRs with active development on them labels Feb 21, 2025
@dkamburov dkamburov requested a review from skrustev February 26, 2025 15:12
skrustev
skrustev previously approved these changes Feb 26, 2025
@skrustev
Copy link
Member

skrustev commented Feb 26, 2025

I assume you have checked that all methods are working correctly.

  1. I have suspicion that the selected getter/setter might not work judging by how it is implemented in the IgxPivotRow, so make sure they work along with everything in the IgxPivotGridRow

  2. The key for a single pivot row also is a bit of a weird concept now that I think about it. Also doesn't seem to be close to how it is implemented in the Pivot Grid. Might be better to return the full key for a row. That would mean getting the record key by the last row dimension and the selection would check if the selected key in the selection service is a subset of that pivot row key.

@skrustev skrustev self-requested a review February 26, 2025 17:55
@tishko0 tishko0 added the 🛠️ status: in-development Issues and PRs with active development on them label Feb 28, 2025
@tishko0 tishko0 removed the ❌ status: awaiting-test PRs awaiting manual verification label Feb 28, 2025
@dkamburov dkamburov added version: 19.2.x ❌ status: awaiting-test PRs awaiting manual verification and removed version: 19.1.x 🛠️ status: in-development Issues and PRs with active development on them labels Mar 5, 2025
skrustev
skrustev previously approved these changes Mar 18, 2025
@skrustev skrustev self-requested a review April 2, 2025 07:42
skrustev
skrustev previously approved these changes Apr 2, 2025
@ChronosSF ChronosSF changed the base branch from master to 19.2.x April 16, 2025 17:05
@ChronosSF ChronosSF dismissed skrustev’s stale review April 16, 2025 17:05

The base branch was changed.

@MarielaTihova MarielaTihova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 29, 2025
@skrustev skrustev self-requested a review June 19, 2025 13:27
skrustev
skrustev previously approved these changes Jun 19, 2025
@dkamburov dkamburov merged commit becbd2e into 19.2.x Jun 20, 2025
5 checks passed
@dkamburov dkamburov deleted the ttonev/fix-14970-master branch June 20, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grid: pivot version: 19.2.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cellClick's event args in Pivot Grid not all resolvable

4 participants