[Query Builder] drag and drop refactor without DOM manipulations - 19.1.x#15530
Closed
ivanvpetrov wants to merge 50 commits into19.1.xfrom
Closed
[Query Builder] drag and drop refactor without DOM manipulations - 19.1.x#15530ivanvpetrov wants to merge 50 commits into19.1.xfrom
ivanvpetrov wants to merge 50 commits into19.1.xfrom
Conversation
…rov/query-builder-drag-and-drop-refactor-remake
ivanvpetrov
added
🆕 status: new
query-builder
version: 19.1.x
❌ status: awaiting-test
This was referenced Mar 18, 2025
ivanvpetrov
changed the title
ChronosSF
reviewed
Mar 18, 2025
| if (!this._isKeyboardDrag) { | ||
| this.sourceElement.style.display = 'none'; | ||
| if (!this.isKeyboardDrag) { | ||
| //TODO display-none should be done by angular? |
Member
There was a problem hiding this comment.
possibly forgotten to resolve TODO
Contributor
Author
There was a problem hiding this comment.
At first I was thinking of handling this in the Angular component, but it got too complicated to do so.
Also I saw similar code already in place in other components, so it seemed fine to leave it like this.
//TODO removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch and PR remake to try solve test disconnecting issue
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)