Skip to content

chore(*): expose change events for analyzer#15749

Merged
damyanpetev merged 12 commits into19.2.xfrom
dkamburov/expose-change
Apr 29, 2025
Merged

chore(*): expose change events for analyzer#15749
damyanpetev merged 12 commits into19.2.xfrom
dkamburov/expose-change

Conversation

@dkamburov
Copy link
Contributor

@dkamburov dkamburov commented Apr 23, 2025

Closes # https://infragistics.visualstudio.com/Indigo_Platform/_workitems/edit/37410

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

gedinakova and others added 4 commits April 17, 2025 09:52
Co-authored-by: Stamen Stoychev <sstoychev@infragistics.com>
Co-authored-by: Teodosia Hristodorova <52423497+teodosiah@users.noreply.github.com>
@dkamburov dkamburov added squash-merge Merge PR with "Squash and Merge" option grid 💠 grid: elements version: 19.2.x ❌ status: awaiting-test PRs awaiting manual verification labels Apr 23, 2025
mddragnev
mddragnev previously approved these changes Apr 28, 2025
@dkamburov dkamburov changed the base branch from master to 19.2.x April 29, 2025 08:26
@dkamburov dkamburov dismissed mddragnev’s stale review April 29, 2025 08:26

The base branch was changed.

mddragnev
mddragnev previously approved these changes Apr 29, 2025
damyanpetev
damyanpetev previously approved these changes Apr 29, 2025
Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits that can wait, otherwise LGTM

@Output()
public expansionStatesChange = new EventEmitter<Map<any, boolean>>();

/* blazorInclude */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can prob drop the analyzer tag now, but it doesn't cause problems being there so no rush.

* </igx-column>
* ```
*
* @memberof IgxColumnComponent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also really no point to this tag, but that's a global issue to clear out so can be ignored.

@dkamburov dkamburov removed the ❌ status: awaiting-test PRs awaiting manual verification label Apr 29, 2025
@damyanpetev damyanpetev merged commit 4df51e8 into 19.2.x Apr 29, 2025
5 checks passed
@damyanpetev damyanpetev deleted the dkamburov/expose-change branch April 29, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants