Sync aria-required with required state - 20.0.x#16002
Closed
IvanKitanov17 wants to merge 4 commits into20.0.xfrom
Closed
Sync aria-required with required state - 20.0.x#16002IvanKitanov17 wants to merge 4 commits into20.0.xfrom
IvanKitanov17 wants to merge 4 commits into20.0.xfrom
Conversation
IvanKitanov17
added
♿ a11y
ChronosSF
requested changes
Jul 11, 2025
| protected manageRequiredAsterisk(): void { | ||
| if (this.ngControl) { | ||
| this.inputGroup.isRequired = this.required; | ||
| this.comboInput.nativeElement.setAttribute('aria-required', this.required.toString()); |
Member
There was a problem hiding this comment.
Is there any reason why this is not part of the template?
(apart from, I guess, having to add it to both the simple combo and the combo templates, but I think it doesn't outweigh having a more native angular implementation)
Member
|
Closing as I retrofitted the changes in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16000
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)