Skip to content

fix(grid): Add flex:1 to the display container so that it grows or shrinks to the available width of the grid #16036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkamburov merged 9 commits into from
Sep 25, 2025
Merged

fix(grid): Add flex:1 to the display container so that it grows or shrinks to the available width of the grid #16036

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
23b3939
test(hgrid): add a test
mddragnev Jul 8, 2025
4739eb5
fix(*): Add flex-grow and flex shrink so that the display container t…
mddragnev Jul 8, 2025
323d0fc
Merge branch '20.0.x' into mddragnev/fix-16035
simeonoff Jul 9, 2025
1beada7
Merge branch '20.0.x' into mddragnev/fix-16035
ChronosSF Jul 18, 2025
d73e3b7
chore(*): Remove calculation of offset when pinning to the right side
mddragnev Aug 25, 2025
295796c
Merge branch '20.0.x' of https://github.com/IgniteUI/igniteui-angular…
mddragnev Aug 25, 2025
cdb906b
lint(*): fix lint
mddragnev Aug 25, 2025
c1c95f5
chore(*): fix row drag indicator growing too much
mddragnev Aug 26, 2025
cbe633e
Merge branch '20.0.x' into mddragnev/fix-16035
dkamburov Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,6 +1274,7 @@
%grid-display-container-tr {
width: 100%;
overflow: visible;
flex: 1;
Copy link
Contributor

@MayaKirova MayaKirova Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is fine, however since it changes the size of the cell's virtual container you'll also have to change how right pinning positions the cells. It currently sets an incorrect offset so if you pin any column to the right, you'll see that it's not correctly positioned to the right edge of the grid:

image

}

%grid-mrl-block {
Expand Down
14 changes: 13 additions & 1 deletion projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,18 @@ describe('Basic IgxHierarchicalGrid #hGrid', () => {
);
jasmine.getEnv().allowRespy(false);
});

it('should calculate correct column headers width when rowSelection + expand indicators', () => {
hierarchicalGrid.rowSelection = 'multiple';
fixture.detectChanges();

const headerRowElement = hierarchicalGrid.nativeElement.querySelector("igx-grid-header-row");
const headerRowDiv = headerRowElement.querySelector(".igx-grid__tr");
const headerRowChildren = Array.from(headerRowDiv.children);

const elementsWidth = headerRowChildren.reduce((acc,el) => acc+(el as HTMLElement).offsetWidth, 0);
expect(elementsWidth).toEqual((headerRowDiv as HTMLElement).offsetWidth);
});
});

describe('IgxHierarchicalGrid Row Islands #hGrid', () => {
Expand Down Expand Up @@ -1690,7 +1702,7 @@ describe('Basic IgxHierarchicalGrid #hGrid', () => {
UIInteractions.simulateClickAndSelectEvent(row.expander);
fixture.detectChanges();

let childGrid = hierarchicalGrid.gridAPI.getChildGrids()[0];
const childGrid = hierarchicalGrid.gridAPI.getChildGrids()[0];
const childRow = childGrid.gridAPI.get_row_by_index(0) as IgxHierarchicalRowComponent;
UIInteractions.simulateClickAndSelectEvent(childRow.expander);
fixture.detectChanges();
Expand Down
Loading