-
Notifications
You must be signed in to change notification settings - Fork 159
Align Date & Date Range Picker props related to calendar with WC #16141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ddaribo
wants to merge
18
commits into
master
Choose a base branch
from
bpachilova/dp-drp-calendar-props-16131
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f80508
to
421e62a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📈 enhancement
📅 date-picker
📅 date-range-picker
🛠️ status: in-development
Issues and PRs with active development on them
version: 20.1.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16131
Introduces the missing properties listed in the issue description table.
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)Additional behaviors that are addressed as a result of introducing the new props:
Dynamic value update on typing - Date Picker
Issue: In WC, typing updates the selected calendar date; in Angular, it did not.
WC:
Angular:
Commit: feat(dp): update calendar selection on typing + test
Disabled date handling on value change
Issue: Angular blocks selecting disabled dates via API/model binding; WC allows it. When changing from a valid date to a disabled one via input the following is observed.
WC omits the previous selection, correctly reflecting the change. Since the disabled dates are part of the calendar/date range picker value, at this point the component would become invalid:
Angular shows last valid date as selected: Note: Behavior visible only after fix from (1), as otherwise the component would not reflect the newly typed value. Also can only be tested with the logic from this PR, which allows the picker to remain open while typing:
Commit: refactor(calendar): don't block selection for disabled date through model/API
Active date with min/max restrictions
WC: Active date is value or current date, even if outside min/max, if set.
Angular: Additional logic forces active (view) date to min/max if value is out of range, but ignores
disabledDates
- so is rather incomplete - ref here. The PR currently omits this logic, as such handling was not discussed for the Web Components DP & DRP.Typing cross-month/year should update the days view
IgcDateRangePicker
; also not currently working for WC Date Picker - issue logged).WC
Angular - this cannot be observed before the enhancements of (1) and the close behavior PR, as the calendar is always closed on typing prior to the WC alignment.
Issue: WC DRP reflects a typed single date as the start (single-day) range in the calendar; Angular DRP did not.
WC
Angular
Commit: feat(drp): typing a single value results in calendar range of single date