fix(tooltip): force close shared tooltip when hovering another target - 20.1.x#16291
Merged
kacheshmarova merged 10 commits into20.1.xfrom Oct 23, 2025
Merged
fix(tooltip): force close shared tooltip when hovering another target - 20.1.x#16291kacheshmarova merged 10 commits into20.1.xfrom
kacheshmarova merged 10 commits into20.1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where shared tooltips weren't properly closing when hovering over another target, addressing issue #16288. The fix ensures that when a single tooltip is used across multiple targets, it immediately closes for the previous target when hovering over a new one.
Key changes:
- Refactored the
stopAnimationsmethod to remove the force parameter and simplified its functionality - Added a new
forceClosemethod to handle immediate tooltip closure with proper animation handling - Updated the tooltip target directive to use the new
forceClosemethod instead ofstopAnimations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tooltip.directive.ts | Refactored animation handling and added forceClose method for immediate tooltip closure |
| tooltip-target.directive.ts | Updated to use forceClose method when switching between targets |
| tooltip.directive.spec.ts | Added test case for tooltip positioning when no close animation is present |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
projects/igniteui-angular/src/lib/directives/tooltip/tooltip.directive.ts
Outdated
Show resolved
Hide resolved
ChronosSF
approved these changes
Oct 20, 2025
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16288
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)