Skip to content

feat(grid): style inputs in the context of cell #16451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simeonoff merged 9 commits into from
Nov 20, 2025
Merged

feat(grid): style inputs in the context of cell #16451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b54f8a4
feat(grid): style inputs in the context of cell
didimmova Nov 13, 2025
e99d19d
Merge branch 'master' into didimmova/grid-cell-combos
simeonoff Nov 14, 2025
9ec6f81
Merge branch 'master' into didimmova/grid-cell-combos
didimmova Nov 17, 2025
a6a5df9
fix(grid/combo/input): remove unnecessary importants for disabled styles
didimmova Nov 17, 2025
1385d2c
Merge branch 'master' into didimmova/grid-cell-combos
didimmova Nov 18, 2025
f7bf095
Merge branch 'master' into didimmova/grid-cell-combos
desig9stein Nov 18, 2025
7710add
Merge branch 'master' into didimmova/grid-cell-combos
simeonoff Nov 20, 2025
d33a5a8
Merge branch 'master' into didimmova/grid-cell-combos
simeonoff Nov 20, 2025
f6873cd
Merge branch 'master' into didimmova/grid-cell-combos
simeonoff Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/igniteui-angular/core/src/core/styles/components/combo/_combo-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,8 @@

.igx-input-group--disabled {
%igx-combo__toggle-button {
background: var-get($theme, 'toggle-button-background-disabled') !important;
color: var-get($theme, 'toggle-button-foreground-disabled') !important;
background: var-get($theme, 'toggle-button-background-disabled');
color: var-get($theme, 'toggle-button-foreground-disabled');
}

%igx-combo__clear-button {
Expand Down
23 changes: 21 additions & 2 deletions projects/igniteui-angular/core/src/core/styles/components/grid/_grid-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,12 @@
box-shadow: none !important;
border: none !important;
}

.igx-input-group--disabled,
.igx-input-group--disabled igx-prefix,
.igx-input-group--disabled igx-suffix {
color: var-get($theme, 'cell-disabled-color');
}
}

@if $variant != 'indigo' {
Expand Down Expand Up @@ -1196,6 +1202,21 @@
align-items: center;
outline-style: none;

@extend %cell-input-overrides;
Copy link
Contributor

@desig9stein desig9stein Nov 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are extending this here, you can remove that same extend from igx-grid-td--editing since the base class igx-grid_td is always present


> igx-input-group,
igx-combo,
igx-simple-combo,
igx-select,
igx-date-picker,
igx-time-picker {
height: auto;
}

igx-input-group {
background: transparent;
}

@if $variant != 'indigo' {
padding-inline: pad-inline(
map.get($grid-cell-padding-inline, 'compact'),
Expand Down Expand Up @@ -1411,8 +1432,6 @@
&%grid-cell-number {
justify-content: flex-start !important;
}

@extend %cell-input-overrides;
}

%grid-cell--pinned {
Expand Down
8 changes: 4 additions & 4 deletions projects/igniteui-angular/core/src/core/styles/components/input/_input-group-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@
%form-group-display--disabled {
pointer-events: none;
user-select: none;
color: var-get($theme, 'disabled-text-color') !important;
color: var-get($theme, 'disabled-text-color');

igx-prefix,
[igxPrefix] {
Expand Down Expand Up @@ -1445,7 +1445,7 @@
%form-group-input--disabled {
cursor: default;

color: var-get($theme, 'disabled-text-color') !important;
color: var-get($theme, 'disabled-text-color');

&::placeholder {
color: var-get($theme, 'disabled-placeholder-color');
Expand Down Expand Up @@ -1495,7 +1495,7 @@
}

%form-group-textarea--disabled {
color: var-get($theme, 'disabled-text-color') !important;
color: var-get($theme, 'disabled-text-color');
cursor: default;

&::placeholder {
Expand Down Expand Up @@ -2073,7 +2073,7 @@
}

%fluent-label-disabled {
color: var-get($theme, 'disabled-text-color') !important;
color: var-get($theme, 'disabled-text-color');
}

%fluent-label-filled {
Expand Down
Loading