Skip to content

fix web components router navigation #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lipata merged 2 commits into from
Dec 5, 2024
Merged

fix web components router navigation #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf3703
fix(web-components): fix the step for updating the router navigation …
Dec 4, 2024
750cc38
Merge branch 'master' into hhristov/fix-web-components-navigation
Lipata Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "igniteui-cli",
"version": "14.3.4",
"version": "14.3.5-beta.0",
"description": "CLI tool for creating Ignite UI projects",
"keywords": [
"CLI",
Expand Down Expand Up @@ -76,8 +76,8 @@
"all": true
},
"dependencies": {
"@igniteui/angular-templates": "~19.0.1434",
"@igniteui/cli-core": "~14.3.4",
"@igniteui/angular-templates": "~19.0.1435-beta.0",
"@igniteui/cli-core": "~14.3.5-beta.0",
"@inquirer/prompts": "^5.4.0",
"@types/yargs": "^17.0.33",
"chalk": "^5.3.0",
Expand Down
4 changes: 1 addition & 3 deletions ...plates/webcomponents/igc-ts/projects/_base/files/__dot__github/workflows/github-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ jobs:
# cache: 'npm' # enable after committing lock file from first install
- run: npm i # replace with 'npm ci' after committing lock file from first install
- name: Update Router Navigation
run: |
sed -i "s|Router.go(\`/|Router.go(\`/${{ github.event.repository.name }}/|g" ./src/app/app.ts
sed -i "s|Router.go(\`/|Router.go(\`/${{ github.event.repository.name }}/|g" ./src/app/home/home.ts
run: find ./src -type f -name "*.ts" -exec sed -i "s|Router.go(\`/|Router.go(\`/${{ github.event.repository.name }}/|g" {} \;
- run: npm run build
- name: Update base href in index.html
run: |
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@igniteui/cli-core",
"version": "14.3.4",
"version": "14.3.5-beta.0",
"description": "Base types and functionality for Ignite UI CLI",
"repository": {
"type": "git",
Expand Down
4 changes: 2 additions & 2 deletions packages/igx-templates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@igniteui/angular-templates",
"version": "19.0.1434",
"version": "19.0.1435-beta.0",
"description": "Templates for Ignite UI for Angular projects and components",
"repository": {
"type": "git",
Expand All @@ -12,7 +12,7 @@
"author": "Infragistics",
"license": "MIT",
"dependencies": {
"@igniteui/cli-core": "~14.3.4",
"@igniteui/cli-core": "~14.3.5-beta.0",
"typescript": "~5.5.4"
}
}
6 changes: 3 additions & 3 deletions packages/ng-schematics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@igniteui/angular-schematics",
"version": "19.0.1434",
"version": "19.0.1435-beta.0",
"description": "Ignite UI for Angular Schematics for ng new and ng generate",
"repository": {
"type": "git",
Expand All @@ -20,8 +20,8 @@
"dependencies": {
"@angular-devkit/core": "^19.0.0",
"@angular-devkit/schematics": "^19.0.0",
"@igniteui/angular-templates": "~19.0.1434",
"@igniteui/cli-core": "~14.3.4",
"@igniteui/angular-templates": "~19.0.1435-beta.0",
"@igniteui/cli-core": "~14.3.5-beta.0",
"@schematics/angular": "~19.0.0",
"minimatch": "^10.0.1",
"rxjs": "^7.8.1"
Expand Down
Loading