refactor(columns): rename column properties #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanpetev
force-pushed
the
dpetev/column-props
branch
from
eb01dcf to
fd28d39
Compare
Pull Request Test Coverage Report for Build 20135696285Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR renames column configuration properties to improve API clarity and consistency. The changes rename key to field, type to dataType, and headerText to header across the entire codebase.
- Property renaming:
key→field,type→dataType,headerText→header - Updated all test files to use the new property names
- Updated component implementations and controllers to reference the new properties
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/utils/row-fixture.ts | Updated cell finder to use column.field |
| test/utils/grid-fixture.ts | Updated column configuration to use new property names (field, header, dataType) |
| test/resize.test.ts | Updated test cases to use field instead of key |
| test/grid.properties.test.ts | Updated tests to use new property names and iteration variable |
| test/data-operation/sort-ui.test.ts | Updated test cases to use field instead of key |
| test/data-operation/filter.test.ts | Updated column configuration creation to use field and dataType |
| test/data-operation/filter-ui.test.ts | Updated test cases to use new property names |
| test/column-config.test.ts | Updated all column configuration tests to use new property names |
| src/internal/utils.ts | Updated utility functions to use field and dataType |
| src/internal/types.ts | Updated type definitions and documentation for renamed properties |
| src/internal/constants.ts | Updated default column configuration to use new property names |
| src/controllers/state.ts | Updated column finder to use field |
| src/controllers/sort.ts | Updated sort expression preparation to use field |
| src/controllers/resize.ts | Updated resize logic to use field |
| src/controllers/navigation.ts | Updated navigation logic to use field |
| src/controllers/filter.ts | Updated filter expression creation to use field |
| src/components/row.ts | Updated cell rendering to use field for data access |
| src/components/header.ts | Updated header rendering to use field and header |
| src/components/header-row.ts | Updated header row filtering state check to use field |
| src/components/grid.ts | Updated column lookup to use field |
| src/components/filter-row.ts | Updated filter row logic to use field and dataType |
| src/components/column.ts | Updated property definitions and documentation |
| demo/demo.ts | Updated demo column configurations and usage to new property names |
| CHANGELOG.md | Documented breaking changes for property renames |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export interface BaseColumnConfiguration<T extends object, K extends Keys<T> = Keys<T>> { | ||
| /** | ||
| * The field for from the data the this column will reference. | ||
| * The field from the data for this column. |
There was a problem hiding this comment.
Corrected grammar from 'The field from the data for this column' to 'The field from the data that this column references'.
Suggested change
| * The field from the data for this column. | |
| * The field from the data that this column references. |
rkaraivanov
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.