refactor(themes): consume grid schemas from theming package #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desig9stein
added
🪛 enhancement
Pull Request Test Coverage Report for Build 19890096273Details
💛 - Coveralls |
rkaraivanov
approved these changes
Nov 28, 2025
SisIvanova
added
💥 status: in-test
SisIvanova
requested changes
Dec 2, 2025
| border-block-end: $row-border-width $row-border-style $row-border-color; | ||
| background: $row-odd-background; | ||
| color: $row-odd-text-color; | ||
| border-block-end: rem(1px) solid var-get($theme, 'row-border-color'); |
There was a problem hiding this comment.
You can use --row-border-style and --row-border-width as before, instead of hardcoded values.
Contributor
Author
There was a problem hiding this comment.
The grid schema does not contain those props
| border-bottom: 0; | ||
| } | ||
|
|
||
| :host(:nth-of-type(odd)) { |
SisIvanova
added
✅ status: verified
SisIvanova
approved these changes
Dec 3, 2025
damyanpetev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4