Skip to content

Conversation

@damyanpetev
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Dec 4, 2025

Pull Request Test Coverage Report for Build 20102296012

Details

  • 26 of 27 (96.3%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 96.223%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/sort.ts 12 13 92.31%
Files with Coverage Reduction New Missed Lines %
src/controllers/sort.ts 3 92.73%
Totals Coverage Status
Change from base Build 20101734958: -0.1%
Covered Lines: 2979
Relevant Lines: 3077

💛 - Coveralls

@kdinev kdinev requested a review from Copilot December 9, 2025 12:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the sorting API to improve naming consistency and simplify the configuration interface. The changes rename types and properties to better reflect their purpose while removing the triState option by making it always enabled.

Key changes:

  • Renamed sorting-related types and properties throughout the codebase for better clarity (SortExpressionSortingExpression, sortConfigurationsortingOptions)
  • Simplified sorting configuration by replacing boolean multiple property with string-based mode property and removing triState option
  • Removed redundant test cases for non-tri-state sorting scenarios

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/operations/sort/types.ts Renamed BaseSortExpression and SortExpression types to BaseSortingExpression and SortingExpression
src/internal/types.ts Renamed GridSortConfiguration to GridLiteSortingOptions and replaced multiple/triState booleans with mode string property
src/components/grid.ts Updated grid component to use renamed types and properties (sortingOptions, sortingExpressions)
src/operations/sort.ts Updated to use renamed SortingExpression type
src/controllers/sort.ts Updated sort controller to use new API and hardcoded tri-state behavior
src/components/header.ts Updated header component to check sorting mode using new API
src/index.ts Updated exported type names to reflect API changes
test/data-operation/sort.test.ts Updated test to use renamed SortingExpression type
test/data-operation/sort-ui.test.ts Updated tests to use new sorting options API and removed non-tri-state test cases
test/grid.properties.test.ts Updated property tests to use renamed sortingExpressions property
test/utils/grid-fixture.ts Updated test fixture to use renamed SortingExpression type
CHANGELOG.md Added changelog documenting all breaking changes in the sorting API refactor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@damyanpetev damyanpetev marked this pull request as ready for review December 10, 2025 14:37
@damyanpetev damyanpetev merged commit 37c7886 into master Dec 10, 2025
5 checks passed
@damyanpetev damyanpetev deleted the dpetev/sorting-api branch December 10, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants