refactor(query-builder): update schemas based on new design #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desig9stein
added
❌ status: awaiting-test
simeonoff
changed the title
simeonoff
changed the title
* refactor(color): update color function to work with named colors The color function will not work with named colors for keys in a palette. This PR fixes that so an expression like `color($palette, gray, 200)` can still work with palettes where the `gray` variants are keyed to a string. * fix(var-get): return properly formatted error message * refactor(palettes): always interpolate keys to string type * refactor(colors): add quotes to contrast and raw colors * refactor(palettes): refactor indigo handmate palettes to use strings as keys
Co-authored-by: Simeon Simeonoff <[email protected]>
…y-builder-schemas
Contributor
Author
|
Closing in favor of #378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.