Skip to content

Conversation

@desig9stein
Copy link
Contributor

Add styles for date-selected-special-* and improve date-current-* and date-special-* theme handling across schemas, fix some SASS doc issues, and also rearange/group the props by state so it's easy to read

Copy link
Contributor

@SisIvanova SisIvanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Calendar Design Hand-off:

  • $weekday-color in dark material theme should be gray-500;
  • $week-number-foreground in dark fluent theme should be gray-500;

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the calendar component schemas by organizing theme properties by state, improving documentation consistency, and expanding theme coverage for special and current date states. The changes enhance maintainability and provide more comprehensive styling options for date-selected-special and related states.

  • Adds missing date-selected-special-* theme properties (foreground, background, and their hover/focus variants) across all schema files
  • Improves SASS documentation by standardizing state descriptions (:hover, :focus) and adding missing property documentation
  • Reorganizes theme properties in the main theme function file by grouping them logically by state for better readability

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
sass/themes/schemas/components/light/calendar/_days-view.scss Adds date-selected-special styles, reorganizes properties by state, expands documentation for special date ranges, and adds weekday/week-number color properties
sass/themes/schemas/components/dark/calendar/_days-view.scss Adds missing dark theme variants for special date states, expands border color documentation, and adds weekday/week-number properties
sass/themes/components/calendar/_calendar-theme.scss Reorganizes function parameters by state groupings, standardizes documentation format, and adds comprehensive comments for property organization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@desig9stein desig9stein requested a review from Copilot November 13, 2025 08:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

sass/themes/schemas/components/light/calendar/_days-view.scss:1

  • Documentation contains redundant text: 'The :hover outline color around a special date on hover' repeats the hover concept unnecessarily. Should be 'The :hover outline color around a special date'.
@use '../../../../../utils/map' as *;

sass/themes/schemas/components/light/calendar/_days-view.scss:1

  • Documentation incorrectly states 'on hover' but the property is date-special-focus-border-color which should describe the ':focus' state. Should be 'The :focus outline color around a special date'.
@use '../../../../../utils/map' as *;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@desig9stein desig9stein requested a review from Copilot November 13, 2025 09:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@desig9stein desig9stein requested a review from Copilot November 13, 2025 09:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

sass/themes/schemas/components/light/calendar/_days-view.scss:1

  • [nitpick] The magic number 0.5 for the alpha value should be extracted as a named constant or documented to explain why 50% opacity is appropriate for the preview border.
@use '../../../../../utils/map' as *;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@desig9stein desig9stein requested a review from Copilot November 13, 2025 09:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

sass/themes/schemas/components/light/calendar/_days-view.scss:1

  • [nitpick] The change from var(--date-selected-background) to hsla(from var(--date-selected-background) h s l / 0.5) adds transparency but lacks a corresponding documentation update. Consider adding a comment explaining this opacity adjustment.
@use '../../../../../utils/map' as *;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@desig9stein desig9stein requested a review from Copilot November 13, 2025 09:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@simeonoff simeonoff enabled auto-merge November 20, 2025 13:21
@simeonoff simeonoff added this pull request to the merge queue Nov 20, 2025
Merged via the queue into master with commit 65095c7 Nov 20, 2025
3 checks passed
@simeonoff simeonoff deleted the mpopov/refactor-calendar-schemas branch November 20, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants