-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(calendar): Schemas #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ove `date-current-*` and `date-special-*` theme handling across schemas
…ap schema to use correct value
… schemas for improved range selection customization
SisIvanova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Calendar Design Hand-off:
- $weekday-color in dark material theme should be gray-500;
- $week-number-foreground in dark fluent theme should be gray-500;
…styles in dark schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the calendar component schemas by organizing theme properties by state, improving documentation consistency, and expanding theme coverage for special and current date states. The changes enhance maintainability and provide more comprehensive styling options for date-selected-special and related states.
- Adds missing
date-selected-special-*theme properties (foreground, background, and their hover/focus variants) across all schema files - Improves SASS documentation by standardizing state descriptions (
:hover,:focus) and adding missing property documentation - Reorganizes theme properties in the main theme function file by grouping them logically by state for better readability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| sass/themes/schemas/components/light/calendar/_days-view.scss | Adds date-selected-special styles, reorganizes properties by state, expands documentation for special date ranges, and adds weekday/week-number color properties |
| sass/themes/schemas/components/dark/calendar/_days-view.scss | Adds missing dark theme variants for special date states, expands border color documentation, and adds weekday/week-number properties |
| sass/themes/components/calendar/_calendar-theme.scss | Reorganizes function parameters by state groupings, standardizes documentation format, and adds comprehensive comments for property organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (2)
sass/themes/schemas/components/light/calendar/_days-view.scss:1
- Documentation contains redundant text: 'The :hover outline color around a special date on hover' repeats the hover concept unnecessarily. Should be 'The :hover outline color around a special date'.
@use '../../../../../utils/map' as *;
sass/themes/schemas/components/light/calendar/_days-view.scss:1
- Documentation incorrectly states 'on hover' but the property is
date-special-focus-border-colorwhich should describe the ':focus' state. Should be 'The :focus outline color around a special date'.
@use '../../../../../utils/map' as *;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ecial-focus-*` styles in light schema
…ma to improve contrast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
sass/themes/schemas/components/light/calendar/_days-view.scss:1
- [nitpick] The magic number 0.5 for the alpha value should be extracted as a named constant or documented to explain why 50% opacity is appropriate for the preview border.
@use '../../../../../utils/map' as *;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ecial-*` sass doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
sass/themes/schemas/components/light/calendar/_days-view.scss:1
- [nitpick] The change from
var(--date-selected-background)tohsla(from var(--date-selected-background) h s l / 0.5)adds transparency but lacks a corresponding documentation update. Consider adding a comment explaining this opacity adjustment.
@use '../../../../../utils/map' as *;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add styles for
date-selected-special-*and improvedate-current-*anddate-special-*theme handling across schemas, fix some SASS doc issues, and also rearange/group the props by state so it's easy to read