refactor(input-group/validator): extend validator schemas in input group #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didimmova
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the input-group and validator schemas to improve code organization by extending validator schemas into input-group schemas, reducing duplication of error-related color properties.
- Extends validator schemas in light and dark input-group schemas
- Adds error-related color properties to input-group documentation and theme parameters
- Removes redundant
helper-text-colordefinition from$light-input-group
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sass/themes/schemas/components/light/_input-group.scss | Imports validator schema, extends $light-input-group and $indigo-input-group with validator schemas, adds error color properties to documentation |
| sass/themes/schemas/components/dark/_input-group.scss | Imports dark validator schema, extends $dark-indigo-input-group with validator schema, adds error color properties to documentation |
| sass/themes/components/input/_input-theme.scss | Adds text-error-color and icon-error-color parameters to theme function documentation and implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SisIvanova
previously approved these changes
Nov 12, 2025
Co-authored-by: Silvia Ivanova <[email protected]>
Co-authored-by: Silvia Ivanova <[email protected]>
SisIvanova
approved these changes
Nov 13, 2025
SisIvanova
added
✅ status: verified
simeonoff
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to IgniteUI/igniteui-webcomponents#1916