Skip to content

fix(dialog): backdrop & overlay #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simeonoff merged 2 commits into from
Nov 27, 2025
Merged

fix(dialog): backdrop & overlay #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b13027
fix(dialog): backdrop & overlay
SisIvanova Nov 25, 2025
89a31b4
Merge branch '23.x.x' into sivanova/dialog-fixes-23.x.x
simeonoff Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sass/themes/schemas/components/dark/_overlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@ $dark-material-overlay: extend(

/// Generates a dark fluent overlay schema.
/// @type {Map}
/// @property {Color} background-color [rgba(0, 0, 0, .4)] - The background color used for modal overlays.
/// @requires $fluent-overlay
$dark-fluent-overlay: extend(
$fluent-overlay,
(
background-color: rgb(0 0 0 / 0.4),
_meta: (
theme: 'fluent',
variant: 'dark',
Expand Down
11 changes: 1 addition & 10 deletions sass/themes/schemas/components/light/_dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/// @prop {Map} title-color [color: ('gray', 900)] - The dialog title text color.
/// @prop {Map} message-color [color: ('gray', 600)] - The dialog message text color.
/// @prop {Color} border-color [transparent] - The border color for dialog component.
/// @prop {Map} backdrop [color: ('gray', 50, .54)] - The dialog backdrop color.
/// @prop {Map} backdrop [color: ('gray', 500, .54)] - The dialog backdrop color.
/// @prop {Number} elevation [24] - The elevation level, between 0-24, to be used for the dialog.
/// @prop {List} border-radius [(rem(4px), rem(0), rem(36px))] - The border radius used for dialog.
/// @prop {Number} default-size [2] - The default size used for the dialog component.
Expand Down Expand Up @@ -102,7 +102,6 @@ $material-dialog: extend(

/// Generates a fluent dialog schema.
/// @type {Map}
/// @prop {Map} backdrop [color: ('gray', 900, .4)] - The dialog backdrop color.
/// @prop {List} border-radius [(rem(2px), rem(0), rem(36px))] - The border radius used for dialog.
/// @prop {Map} message-color [color: ('gray', 700)] - The dialog message text color.
/// @prop {Map} typography [
Expand All @@ -113,14 +112,6 @@ $material-dialog: extend(
$fluent-dialog: extend(
$light-dialog,
(
backdrop: (
color: (
'gray',
900,
0.4,
),
),

border-radius: (
border-radius: (
rem(2px),
Expand Down
2 changes: 0 additions & 2 deletions sass/themes/schemas/components/light/_overlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,10 @@ $material-overlay: extend(

/// Generates a fluent overlay schema.
/// @type {Map}
/// @prop {Color} background-color [rgba(255, 255, 255, .4)] - The background color used for modal overlays.
/// @requires {Map} $light-overlay
$fluent-overlay: extend(
$light-overlay,
(
background-color: rgb(255 255 255 / 0.4),
_meta: (
theme: 'fluent',
variant: 'light',
Expand Down