chore(*): Updated chat overview sample with new context...#1045
Open
gedinakova wants to merge 2 commits intovnextfrom
Open
chore(*): Updated chat overview sample with new context...#1045gedinakova wants to merge 2 commits intovnextfrom
gedinakova wants to merge 2 commits intovnextfrom
Conversation
damyanpetev
reviewed
Sep 23, 2025
| : nothing; | ||
| }; | ||
|
|
||
| private messageContentTemplate = (msg: any) => { |
Member
There was a problem hiding this comment.
Shouldn't this be msg: IgcChatMessage? Prefer a type if available before any :)
damyanpetev
reviewed
Sep 23, 2025
| @@ -83,26 +200,43 @@ export class ChatOverview { | |||
| public onMessageCreated = (e: CustomEvent) => { | |||
Member
There was a problem hiding this comment.
And this would be CustomEvent<IgcChatMessage> too, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as per George's suggestions.