Skip to content

Fix circular progress value and keyframes names#1543

Merged
simeonoff merged 8 commits intomasterfrom
mpopov/progressbar/refactor-progressbar
Feb 3, 2025
Merged

Fix circular progress value and keyframes names#1543
simeonoff merged 8 commits intomasterfrom
mpopov/progressbar/refactor-progressbar

Conversation

@desig9stein
Copy link
Contributor

closes #1542

@didimmova
Copy link
Contributor

When in RTL mode, the circular progress should remain filling clockwise.

@simeonoff
Copy link
Collaborator

When in RTL mode, the circular progress should remain filling clockwise.

Why?

@didimmova
Copy link
Contributor

When in RTL mode, the circular progress should remain filling clockwise.

Why?

https://m3.material.io/components/progress-indicators/guidelines#ee16854f-800e-4470-a102-8d01918582b4
Screenshot 2025-01-28 at 14 12 19

@simeonoff
Copy link
Collaborator

When in RTL mode, the circular progress should remain filling clockwise.

Why?

https://m3.material.io/components/progress-indicators/guidelines#ee16854f-800e-4470-a102-8d01918582b4 Screenshot 2025-01-28 at 14 12 19

Thank you!

@simeonoff simeonoff self-requested a review January 29, 2025 08:37
@simeonoff simeonoff merged commit f162937 into master Feb 3, 2025
5 checks passed
@simeonoff simeonoff deleted the mpopov/progressbar/refactor-progressbar branch February 3, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Circular progress bar - value should scale with the diameter

3 participants