fix(forms): Setting validation properties on a pristine non-dirty form#1638
Merged
rkaraivanov merged 9 commits intomasterfrom Apr 9, 2025
Merged
fix(forms): Setting validation properties on a pristine non-dirty form#1638rkaraivanov merged 9 commits intomasterfrom
rkaraivanov merged 9 commits intomasterfrom
Conversation
Setting validation properties on a pristine non-dirty form element does not apply invalid styles. Closes #1632
Rewritten the synthetic test for invalidation on a single blur to follow the new behavior of form associated elements. Added tests for validation slots and removed some which are not really applicable. Some code refactoring in the component to follow the coding style guide.
damyanpetev
reviewed
Apr 8, 2025
damyanpetev
approved these changes
Apr 8, 2025
|
I have tested the fix with the attached sample as well as the sample in codegen-output repo : https://github.com/IgniteUI/codegen-output/tree/master/04_Forms/Validation%20Samples/React%20validation and it is working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting validation properties on a pristine non-dirty form element does not apply invalid styles.
Closes #1632