fix(file-input): instantiation fails because of super styles#1647
Merged
rkaraivanov merged 2 commits intomasterfrom Apr 7, 2025
Merged
fix(file-input): instantiation fails because of super styles#1647rkaraivanov merged 2 commits intomasterfrom
rkaraivanov merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/components/file-input/file-input.ts:49
- Using super.styles in static properties may not work as expected; explicitly referencing IgcInputBaseComponent.styles correctly resolves the issue. Please confirm that there are no side effects related to this explicit reference.
public static override styles = [...IgcInputBaseComponent.styles, styles];
rkaraivanov
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.