Skip to content

fix(input-group): fluent theme discrepancies #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simeonoff merged 10 commits into from
Apr 17, 2025
Merged

fix(input-group): fluent theme discrepancies #1651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c7fa510
fix(input-group): fluent theme discrepancies
SisIvanova Apr 9, 2025
fc3664f
refactor(input): update hardcoded values
SisIvanova Apr 10, 2025
0eb2a55
Merge branch 'master' into sivanova/fluent-inputs
SisIvanova Apr 14, 2025
c1eacea
deps(theming): bump to latest version
SisIvanova Apr 14, 2025
5a793f2
fix(input): requested changes
SisIvanova Apr 15, 2025
da0bfaa
fix(textarea): wrong color
SisIvanova Apr 15, 2025
1b04c20
Merge branch 'master' into sivanova/fluent-inputs
simeonoff Apr 15, 2025
f23dff5
Merge branch 'master' into sivanova/fluent-inputs
SisIvanova Apr 15, 2025
8ecfe86
Merge branch 'master' into sivanova/fluent-inputs
simeonoff Apr 15, 2025
98d7a29
fix(date-picker): label focused color
SisIvanova Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/components/date-picker/themes/shared/date-picker.fluent.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,6 @@ $theme: $fluent;
min-height: #{sizable(rem(40px), rem(48px), rem(54px))};
}

:host(:focus-within) {
[part='label'] {
color: color(gray, 800);
}
}

:host([required]) {
[part='label']::after {
color: var-get($theme, 'error-secondary-color');
Expand Down
20 changes: 16 additions & 4 deletions src/components/input/themes/shared/input.fluent.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ $focused-height: calc(var-get($theme, 'size') - #{($focused-border-width * 2)});
}

:host(:focus-within) {
[part='label'] {
color: color(gray, 800);
}

[part^='container'] {
border-color: var-get($theme, 'focused-border-color');
border-width: #{$focused-border-width};
Expand All @@ -110,10 +106,26 @@ $focused-height: calc(var-get($theme, 'size') - #{($focused-border-width * 2)});
}
}

:host([type='search']) {
[part='prefix'] {
background: var(--ig-input-group-input-prefix-background, transparent);
color: var(--ig-input-group-input-prefix-color, var(--ig-primary-500));
}

[part='suffix'] {
background: var(--ig-input-group-input-suffix-background, transparent);
color: var(--ig-input-group-input-suffix-color, var(--ig-primary-500));
}
}

:host([type='search']:focus-within) {
[part='prefix'] {
display: none;
}

[part='suffix'] {
color: var(--ig-input-group-input-suffix-color--focused, var(--ig-gray-900));
}
}

:host([required]) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/textarea/themes/shared/textarea.common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ $theme: $base;

[part~='filled'] {
[part~='input'] {
color: var-get($theme, 'input-prefix-color--filled');
color: var-get($theme, 'filled-text-color');
}

[part~='prefix'] {
Expand Down
2 changes: 1 addition & 1 deletion src/components/textarea/themes/shared/textarea.fluent.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ $theme: $fluent;
transform-origin: top left;
margin-top: 0;
height: auto;
margin-block-end: rem(4px);
margin-block-end: rem(5px);
}

:host([invalid]) {
Expand Down