feat: expose type aliases for custom string union property types#1656
Merged
rkaraivanov merged 7 commits intomasterfrom Apr 15, 2025
Merged
feat: expose type aliases for custom string union property types#1656rkaraivanov merged 7 commits intomasterfrom
rkaraivanov merged 7 commits intomasterfrom
Conversation
damyanpetev
force-pushed
the
dpetev/union-types
branch
from
21cec53 to
2dd5834
Compare
rkaraivanov
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've merged types into more general ones for reuse only where I feel somewhat certain - e.g.
PickerModeshould be valid for Date Range Picker andPopoverScrollStrategypossibly for a tooltip. The rest I've stuck to component-specific types if not enough is shared or is used semantically differently.Also generally all naming feedback is welcome, choosing names is tiresome :D
Skipped types we generally replicate native DOM API - button
type/targetand textareaautocapitalize/inputMode/wrap, since those are subject to change from the DOM and we merely pass them along.PS: This almost certainly degrades the VS Code custom data autocomplete since the type is not inlined now and the plugin doesn't read the expanded type. But that seems to be an issue with the plugin itself taking most types it doesn't recognize as value options, e.g. from official version:
