Skip to content

fix(input-group): bootstrap prefix & suffix border #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simeonoff merged 6 commits into from
Aug 21, 2025
Merged

fix(input-group): bootstrap prefix & suffix border #1820

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3bfc3f6
fix(inputs): bootstrap border
adrianptrv Aug 17, 2025
a484799
fix(inputs): lint errors
adrianptrv Aug 18, 2025
ec88899
chore(input-group): formatting
adrianptrv Aug 18, 2025
cd7a5a5
Merge branch 'master' into apetrov/fix-bootstrap-border
simeonoff Aug 21, 2025
dcd481a
fix(input-group): fix comments + apply padding to all prefix & suffix…
adrianptrv Aug 21, 2025
8a1654f
fix(input-group): change var name
adrianptrv Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/components/combo/themes/shared/combo.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@ $dropdown-theme: dropdown-theme.$bootstrap;
grid-auto-rows: minmax(rem(20px), auto);
margin-block-start: rem(4px);
}

[slot='suffix']:not([part|='toggle'], [part|='clear']),
[slot='prefix'] {
padding-inline: unset;
}

::slotted([slot='suffix']),
::slotted([slot='prefix']) {
padding-inline: pad-inline(rem(8px), rem(12px), rem(14px));
height: 100%;
display: flex;
align-items: center;
}
}

[part='list-wrapper'] {
Expand Down Expand Up @@ -128,4 +141,25 @@ $dropdown-theme: dropdown-theme.$bootstrap;
color: inherit;
}
}

::slotted([slot='suffix']),
[part|='toggle'] {
border-inline-end: .0625rem solid var(--disabled-border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--disabled-border-color);
}
}

:host(:not([disabled])),
:host(:not(:disabled)) {
::slotted([slot='suffix']),
[part|='toggle'] {
border-inline-end: .0625rem solid var(--border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--border-color);
}
}
26 changes: 26 additions & 0 deletions src/components/date-range-picker/themes/shared/date-range-picker.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,29 @@ $theme: $bootstrap;
[part='actions'] {
min-height: #{sizable(rem(47px), rem(54px), rem(64px))};
}

:host(:not([disabled])),
:host(:not(:disabled)) {
::slotted([slot^='prefix-']),
[part|='calendar-icon'] {
border-inline-start: .0625rem solid var(--border-color);
}

::slotted([slot^='suffix-']),
[part|='clear-icon'] {
border-inline-end: .0625rem solid var(--border-color);
}
}

:host(:disabled),
:host([disabled]) {
::slotted([slot^='prefix-']),
[part|='calendar-icon'] {
border-inline-start: .0625rem solid var(--disabled-border-color);
}

::slotted([slot^='suffix-']),
[part|='clear-icon'] {
border-inline-end: .0625rem solid var(--disabled-border-color);
}
}
8 changes: 8 additions & 0 deletions src/components/file-input/themes/shared/file-input.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ $theme-file-input: file-input.$bootstrap;
[part~='file-names'] {
border-color: var-get($theme, 'error-secondary-color');
}

[part~='prefixed'] ::slotted([slot='prefix']) {
border-inline-start-color: var(--error-secondary-color);
}

[part~='suffixed'] ::slotted([slot='suffix']) {
border-inline-end-color: var(--error-secondary-color);
}
}

:host(:not([disabled]):state(ig-invalid):focus-within) {
Expand Down
30 changes: 30 additions & 0 deletions src/components/input/themes/shared/input.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ $theme: $bootstrap;
grid-auto-rows: minmax(rem(20px), auto);
margin-block-start: rem(4px);
}

[part='prefix'] {
border-inline-start-width: 0;
}

[part='suffix'] {
border-inline-end-width: 0;
}
}

[part~='container'] {
Expand Down Expand Up @@ -211,3 +219,25 @@ $theme: $bootstrap;
color: var-get($theme, 'disabled-text-color');
}
}

:host(:not(:disabled, [role='combobox'])),
:host(:not([disabled], [role='combobox'])) {
::slotted([slot='suffix']) {
border-inline-end: .0625rem solid var(--border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--border-color);
}
}

:host(:disabled:not([role='combobox'])),
:host([disabled]:not([role='combobox'])) {
::slotted([slot='suffix']) {
border-inline-end: .0625rem solid var(--disabled-border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--disabled-border-color);
}
}
34 changes: 34 additions & 0 deletions src/components/select/themes/shared/select.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@ $input-theme: input-theme.$bootstrap;
grid-auto-rows: minmax(rem(20px), auto);
margin-block-start: rem(4px);
}

[slot='suffix']:not([part|='toggle']),
[slot='prefix'] {
padding-inline: unset;
}

::slotted([slot='suffix']),
::slotted([slot='prefix']) {
padding-inline: pad-inline(rem(8px), rem(12px), rem(14px));
height: 100%;
display: flex;
align-items: center;
}
}

[part='base'] {
Expand Down Expand Up @@ -45,4 +58,25 @@ $input-theme: input-theme.$bootstrap;
color: inherit;
}
}

::slotted([slot='suffix']),
[part|='toggle'] {
border-inline-end: .0625rem solid var(--disabled-border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--disabled-border-color);
}
}

:host(:not([disabled])),
:host(:not(:disabled)) {
::slotted([slot='suffix']),
[part|='toggle'] {
border-inline-end: .0625rem solid var(--border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--border-color);
}
}
40 changes: 36 additions & 4 deletions src/components/textarea/themes/shared/textarea.bootstrap.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ $theme: $bootstrap;
grid-auto-rows: minmax(rem(20px), auto);
margin-block-start: rem(4px);
}

[part~='prefix'],
[part~='suffix'] {
padding-inline: unset;
}

::slotted([slot="prefix"]),
::slotted([slot="suffix"]) {
padding-inline: pad-inline(rem(10px), rem(12px), rem(12px));
height: 100%;
display: flex;
align-items: center;
}
}

[part~='label'] {
Expand All @@ -30,11 +43,11 @@ $theme: $bootstrap;

[part~='prefixed'] {
[part~='prefix'] {
border-width: rem(1px);
border-block-width: rem(1px);
border-style: solid;
border-color: var-get($theme, 'border-color');
overflow: hidden;
border-inline-end-width: 0;
border-inline-width: 0;
border: {
start: {
start-radius: var-get($theme, 'border-border-radius');
Expand All @@ -59,11 +72,11 @@ $theme: $bootstrap;

[part~='suffixed'] {
[part~='suffix'] {
border-width: rem(1px);
border-block-width: rem(1px);
border-style: solid;
border-color: var-get($theme, 'border-color');
overflow: hidden;
border-inline-start-width: 0;
border-inline-width: 0;
border: {
start: {
end-radius: var-get($theme, 'border-border-radius');
Expand Down Expand Up @@ -157,4 +170,23 @@ textarea {
border: rem(1px) solid var-get($theme, 'disabled-border-color');
box-shadow: none;
}

::slotted([slot='suffix']) {
border-inline-end: .0625rem solid var(--disabled-border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--disabled-border-color);
}
}

:host(:not([disabled])),
:host(:not(:disabled)) {
::slotted([slot='suffix']) {
border-inline-end: .0625rem solid var(--border-color);
}

::slotted([slot='prefix']) {
border-inline-start: .0625rem solid var(--border-color);
}
}