-
Notifications
You must be signed in to change notification settings - Fork 10
Splitter component #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MonikaKirkova
wants to merge
78
commits into
master
Choose a base branch
from
mkirkova/splitter-component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Splitter component #1969
Changes from 49 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
30b6a1c
feat(splitter): initial structure implementation
MonikaKirkova 857ca99
feat(splitter): add initial poc styles
ddaribo f62528e
chore: fix initial styles, add spec file
ddaribo fea9e07
feat(splitter): add splitter-pane props
MonikaKirkova b1f82e4
chore: minor changes; add nested story; test nested
ddaribo 5b3d2fe
feat(splitter): add args for each pane to default story
ddaribo 5d7907d
feat(splitter): add nonCollapsible prop
MonikaKirkova 0abf7b8
feat(splitter): add initial resize logic
MonikaKirkova 96a7364
refactor(splitter): alternative approach to render bars and handle pr…
ddaribo 33d0b78
fix(splitter): make resize work after changes; add updateTarget optio…
ddaribo edee68f
chore: style splitter bar through horizontal/vertical part
ddaribo b7b4e8d
fix(splitter): modify flex prop to allow different sizes
MonikaKirkova a05d121
fix(splitter): revert changes from previous commit
MonikaKirkova 59b3285
chore: style tweaks; more tests; resize fix
ddaribo da506d4
fix: handle shrink differently to reflect proper percentage sizes?
ddaribo 9184867
feat(splitter): implement keyboard navigation
MonikaKirkova 65685bd
feat(splitter): implement splitter events
MonikaKirkova 2e6130d
refactor(splitter): rename to nonResizable; port skip fn for key bind…
ddaribo 5839690
refactor(splitter): move all logic to splitter with start/end slots
MonikaKirkova c3ffbde
refactor existing tests; add initial resize tests; minor refactor
ddaribo f6474e2
chore(splitter): more tests checkpoint
ddaribo 5c61571
checkpoint: refactor key bindings and others
ddaribo d6e61c4
feat: add test for px resize panes exceeding splitter size
ddaribo 5f6da39
fix: add logic to fit pane in splitter
ddaribo b6249d9
Merge branch 'master' into mkirkova/splitter-component
rkaraivanov d08a668
fix(splitter): fix panes width on resize of the window
MonikaKirkova ddad5eb
chore(splitter): more tests, refactor internal styles assignment code
ddaribo eb2e152
fix(splitter): percentage min max constraints scenario
ddaribo 218d90e
Merge branch 'master' into mkirkova/splitter-component
ddaribo 15a03e7
chore(splitter): apply code suggestions; reuse similar tests in funct…
ddaribo b621214
chore(splitter): resize tests checkpoint
ddaribo b3f26ac
fix(splitter): change flex to resolve multiple edge cases
MonikaKirkova dc307ed
feat(splitter): handle RTL
ddaribo 2425e6d
fix(splitter): reset min/max size properties
ddaribo 0bf0cc1
chore(*): rename pane and siblingPane to startPane and endPane
MonikaKirkova 560e2b6
chore: add todo tests
ddaribo 613a53c
Merge branch 'master' into mkirkova/splitter-component
ddaribo b043102
Merge branch 'master' into mkirkova/splitter-component
ddaribo 15e288a
Merge branch 'master' into mkirkova/splitter-component
rkaraivanov 2385230
refactor(splitter): poc implementation without ResizeController
ddaribo 0a518f0
Merge branch 'master' into mkirkova/splitter-component
ddaribo 7d5c553
feat(splitter): event args according to current spec
ddaribo cad9de3
feat(splitter): implement drag and expander icons slots
ddaribo 398ff7f
refactor(splitter): change css parts according to updated spec
ddaribo 3479c45
feat(splitter): props according to current spec
ddaribo 59b58b8
Merge branch 'master' into mkirkova/splitter-component
ddaribo dfcdee4
feat(splitter): single collapsed pane constraint
ddaribo e6a0da9
feat(splitter): add Home/End key bindings and aria attributes
MonikaKirkova 6628b48
chore(splitter): tests checkpoint
ddaribo 40041e8
refactor(splitter): update aria attributes and revert changes in resi…
MonikaKirkova 4ed4b6a
Merge branch 'mkirkova/splitter-component' of https://github.com/Igni…
MonikaKirkova 591aba0
chore(splitter): add tests for nested splitters
MonikaKirkova 41800a0
feat(splitter): more tests
ddaribo a14b47a
refactor(splitter): expander config code
ddaribo 09acf64
test(splitter): add more scenarios from spec
ddaribo acda6f7
feat(splitter): add styles for the splitter
didimmova b26953c
feat(splitter): add indigo shared styles to dark
didimmova 8d9aa91
feat(splitter): handle invalid values and constraints
ddaribo ead250f
feat(splitter): add z-index to focused splitter
didimmova 07ca376
feat(splitter): fix focused and active background and arrows size change
didimmova cd2125e
chore(splitter): use logical properties
didimmova 05cca30
chore(splitter): remove empty lines
didimmova 391f4ba
refactor(splitter): remove willUpdate, _renderBarControls method changes
ddaribo 4a63543
chore(splitter): minor code polishing
ddaribo fa7522f
Merge branch 'master' into mkirkova/splitter-component
ddaribo cd9dcdc
styles(splitter): remove unnecessary styling
didimmova b30655d
chore(splitter): remove custom bar icons slots
ddaribo 2f8e82b
chore(splitter): request update on toggle to ensure aria-valuenow is …
ddaribo 157288d
Merge pull request #2099 from IgniteUI/didimmova/splitter-styles
ddaribo 23e5d46
Merge branch 'master' into mkirkova/splitter-component
ddaribo 6ebeb3c
lint(splitter): fix sass linting errors
simeonoff b0afac5
Merge branch 'master' into mkirkova/splitter-component
rkaraivanov bcd3c80
Merge branch 'master' into mkirkova/splitter-component
didimmova 921d056
Merge branch 'master' into mkirkova/splitter-component
didimmova f8ee6a4
styles(splitter): update splitter styles
didimmova 78c7200
style(splitter): don't remove focus-border on focused+hover
didimmova 4ef1b8a
chore(splitter): fix indigo transitions
didimmova bc1e0f1
chore(splitter): increase hide transition duration in indigo
didimmova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonikaKirkova marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonikaKirkova marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.