Add fleet management grid #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarielaTihova
requested changes
Apr 3, 2025
| private utilizationData: any[] = []; | ||
| private fuelCostsCache: { [key: string]: any[] } = {}; | ||
|
|
||
| async loadAllData(): Promise<void> { |
Contributor
There was a problem hiding this comment.
Can you please align how you get the data based on grid-demos in Angular? It would be better to use a separate request for each instead of using Promise.all() ?
| 'https://www.infragistics.com/grid-examples-data/data/fleet/trip_history.json'; | ||
|
|
||
| export class DataService { | ||
| private vehiclesData: any[] = []; |
Contributor
There was a problem hiding this comment.
Some models for the data here would be nice
| registerIconFromText(gitIssue.name, gitIssue.value, 'imx-icons'); | ||
| } | ||
|
|
||
| @property({ type: Array }) maintenanceData: any[] = []; |
Contributor
There was a problem hiding this comment.
Data type/model here as well
| color: var(--primary-text-color); | ||
| } | ||
| .child-grid { |
Contributor
There was a problem hiding this comment.
Do you need this class if you are not adding any styles to it?
mddragnev
requested changes
Apr 11, 2025
projects/fleet-management-grid/src/components/maintenance.component.ts
Outdated
Show resolved
Hide resolved
projects/fleet-management-grid/src/components/maintenance.component.ts
Outdated
Show resolved
Hide resolved
projects/fleet-management-grid/src/components/trip-history-grid.component.ts
Outdated
Show resolved
Hide resolved
mddragnev
approved these changes
Apr 15, 2025
MarielaTihova
approved these changes
Apr 16, 2025
Contributor
|
@IMinchev64 please resolve conflicts |
mddragnev
approved these changes
Apr 17, 2025
dkamburov
added
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.