Push to prod #44
Push to prod #44
Conversation
* trial to licenseded manual string replace * remove trial string match * remove comma * change trial to licensed logic * use webcomponents * reorder tasks * modify script * use cli * wc string edit * wip check package.json * wip-test package.json * revert change * modify ts string replace * modify tsx scipt * modify script * modify script again * add missing curly brace * adjust script * Separate projects/charts * Traceability improvements * remove commented out code * Improve trial to licensed logging
Added Chart Demos
fix(*): adding min-width to grid containers to ensure render on mobile
Added loading indicator instead of empty grid template while loading data
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds chart examples to the web components grid examples project and prepares the application for production deployment. The changes include adding six new chart types (column, bar, line, pie, step, and polar charts), implementing routing logic to handle chart views, and configuring build optimizations.
- Added six new chart sample projects with their corresponding views and routing
- Enhanced the home view to support toggling between grid and chart sections
- Configured Vite build optimizations and increased memory allocation for builds
- Added loading states to grid components and minimum width constraints
Reviewed Changes
Copilot reviewed 81 out of 94 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Added build configuration with optimization settings for production |
| src/views/home/home-view.ts | Refactored to support both grid and chart sections with dynamic routing and tab management |
| src/views/home/home-view.scss | Increased spacing between action items |
| src/views/charts/*/*-view.ts | Created iframe-based view components for each chart type |
| src/views/charts/*/*-view.scss | Added consistent styling for chart view containers |
| src/app-routing.ts | Added routing configuration for chart paths |
| projects/*/src/*.ts | Added loading state indicators to grid components |
| projects/*/src/*.scss | Added minimum width constraints to prevent layout issues |
| projects/charts/*/* | Added complete chart sample projects with configurations and implementations |
| package.json | Increased Node.js memory allocation for build process |
| azure-pipelines/igniteui-wc-grid-examples.yml | Enhanced build pipeline to handle chart projects and package replacements |
Files not reviewed (6)
- projects/charts/bar-chart/package-lock.json: Language not supported
- projects/charts/column-chart/package-lock.json: Language not supported
- projects/charts/line-chart/package-lock.json: Language not supported
- projects/charts/pie-chart/package-lock.json: Language not supported
- projects/charts/polar-chart/package-lock.json: Language not supported
- projects/charts/step-chart/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| title: "Column Chart", | ||
| theme: "Material", | ||
| themeMode: 'Light', | ||
| content: "Render a collection of data points connected by a straight line to emphasize the amount of change over a period of time", |
There was a problem hiding this comment.
The description for the column chart incorrectly describes a line chart. Column charts display data as vertical bars, not connected points with lines.
| content: "Render a collection of data points connected by a straight line to emphasize the amount of change over a period of time", | |
| content: "Display data as vertical bars to compare values across categories or show changes over time.", |
| title: "Polar Chart", | ||
| theme: "Material", | ||
| themeMode: 'Light', | ||
| content: "Emphasizes the amount of change over a period of time or compares multiple items at once.", |
There was a problem hiding this comment.
The polar chart and step chart have identical descriptions (lines 152 and 160), but polar charts are specifically used for displaying data on a circular grid with angle and radius coordinates, which is distinct from step charts.
| content: "Emphasizes the amount of change over a period of time or compares multiple items at once.", | |
| content: "Displays data on a circular grid using angle and radius coordinates, ideal for visualizing cyclic phenomena or relationships between variables.", |
| if (typeof window !== 'undefined') { | ||
| window.removeEventListener('vaadin-router-location-changed', this.updateCurrentPath); | ||
| window.removeEventListener('resize', this.onResize); | ||
| this.updateTabsBasedOnRoute(window.location.pathname); |
There was a problem hiding this comment.
Calling updateTabsBasedOnRoute in disconnectedCallback is unnecessary and could cause issues. This method updates component state, but the component is being disconnected and will not render. This line should be removed.
| this.updateTabsBasedOnRoute(window.location.pathname); |
No description provided.