Convert projects to sdk style with build props; Update packages#240
Merged
ManlyMarco merged 6 commits intomasterfrom Feb 6, 2026
Merged
Convert projects to sdk style with build props; Update packages#240ManlyMarco merged 6 commits intomasterfrom
ManlyMarco merged 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request modernizes the KKManager solution by converting all projects from the legacy .NET Framework project format to the modern SDK-style project format. The changes centralize build configuration, update package management from packages.config to PackageReference, and update several NuGet package versions.
Changes:
- Converted all .csproj files to SDK-style format with significantly reduced boilerplate
- Introduced Directory.build.props for centralized build configuration and auto-generated Constants class
- Migrated from packages.config to PackageReference for package management
- Updated several NuGet packages to newer versions (MSTest 4.0.1→4.1.0, NuGet.Frameworks 6.14.0→7.0.1, SharpCompress 0.41.0→0.42.1, AWSSDK.S3 4.0.7.14→4.0.18.2)
Reviewed changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Directory.build.props | New centralized build configuration file with version management and auto-generated Constants class |
| src/KKManager.Core/Constants.cs | Deleted - replaced by auto-generated Constants from Directory.build.props |
| src/*/Properties/AssemblyInfo.cs | Deleted from most projects - replaced by auto-generation (kept where needed) |
| src//.csproj | Converted to SDK-style format with PackageReference instead of packages.config |
| src/*/packages.config | Deleted - migrated to PackageReference in .csproj files |
| src/*/app.config | Deleted - assembly binding redirects handled automatically in SDK-style projects |
| src/KKManager.sln | Removed x64 configuration, added solution items folder |
| src/KKManager.Core/Util/OutdatedVersionException.cs | Replaced Constants.LatestReleaseLink with hardcoded URL |
| src/KKManager.Updater/Data/FileContentsCalculator.cs | Changed field visibility from private to internal for serialization |
| src/PortableSettingsProvider/Properties/AssemblyInfo.cs | Changed AssemblyVersion from "1.2.*" to "1.2" |
| src/KKManager/Windows/ToolWindows/Properties/Viewers/*.cs | Renamed classes from *Base to actual names (SideloaderViewerBase→SideloaderViewer, etc.) |
Files not reviewed (2)
- src/KKManager/Windows/ToolWindows/Properties/Viewers/CardInfoViewer.Designer.cs: Language not supported
- src/KKManager/Windows/ToolWindows/Properties/Viewers/SideloaderViewer.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.