Skip to content

Comments

chore: bump minimatch and ajv to higher versions#181

Merged
ImadSaddik merged 1 commit intomasterfrom
security/update_frontend_packages
Feb 21, 2026
Merged

chore: bump minimatch and ajv to higher versions#181
ImadSaddik merged 1 commit intomasterfrom
security/update_frontend_packages

Conversation

@ImadSaddik
Copy link
Owner

@ImadSaddik ImadSaddik commented Feb 21, 2026

Pull request

Description

This PR bumps the version of two packages: minimatch and ajv to fix the CI pipeline.

How to test

Run pnpm audit, you should not see any vulnerability.

Checklist

Check what applies:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have used LLMs responsibly to assist in writing code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed linting and formatting checks
  • I have updated the documentation accordingly

@ImadSaddik ImadSaddik self-assigned this Feb 21, 2026
@ImadSaddik ImadSaddik added Security Pull requests that focus on security Frontend Pull requests that change something in the frontend labels Feb 21, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ImadSaddik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability and security of the project's frontend dependencies. By upgrading key packages and explicitly managing their versions, the changes aim to resolve existing CI pipeline failures and mitigate potential vulnerabilities, ensuring a more robust development environment.

Highlights

  • Dependency Version Bumps: The minimatch and ajv packages have been explicitly bumped to higher versions (10.2.1 and 6.14.0 respectively) to address issues in the CI pipeline.
  • PNPM Overrides Configuration: A new pnpm.overrides section was added to package.json to enforce the desired versions of minimatch and ajv across the project's dependency tree.
  • Lockfile Updates: The pnpm-lock.yaml file was extensively updated to reflect the new versions of minimatch and ajv, as well as their transitive dependencies like balanced-match and brace-expansion. Older, conflicting versions of these packages were removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • frontend/package.json
    • Added a pnpm.overrides section to enforce specific versions for minimatch and ajv.
  • frontend/pnpm-lock.yaml
    • Introduced a top-level overrides section for minimatch and ajv.
    • Updated the ajv package from version 6.12.6 to 6.14.0.
    • Updated the minimatch package to version 10.2.1, consolidating multiple older versions.
    • Updated balanced-match from 1.0.2 to 4.0.3 and brace-expansion to 5.0.2.
    • Removed the concat-map@0.0.1 package entry.
    • Adjusted dependencies for various eslint related packages to use the updated ajv and minimatch versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates minimatch and ajv to newer versions to address security vulnerabilities, which is a good practice. The changes in package.json and pnpm-lock.yaml correctly apply pnpm overrides to enforce the new versions. I have one suggestion regarding the ajv version for future consideration.

@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ImadSaddik ImadSaddik merged commit ffa978b into master Feb 21, 2026
14 checks passed
@ImadSaddik ImadSaddik deleted the security/update_frontend_packages branch February 21, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Pull requests that change something in the frontend Security Pull requests that focus on security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant