CI : Update to GafferHQ/dependencies 10.0.0 #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murraystevenson
force-pushed
the
ciPlatform2024
branch
from
cb434d1 to
ccf0455
Compare
johnhaddon
reviewed
Aug 26, 2025
SConstruct
Outdated
| if env["PLATFORM"] == "win32" : | ||
| pxrVersionHeader = env.FindFile( "pxr/pxr.h", dependencyIncludes ) | ||
| if pxrVersionHeader is not None and "#define PXR_USE_INTERNAL_BOOST_PYTHON\n" in open( str( pxrVersionHeader ) ) : | ||
| # Windows builds currently require both boost_python and USD's internal library, |
Collaborator
Author
There was a problem hiding this comment.
A bit of an odd one. From this patch, it appears this is how Cortex has been built for the dependencies-10 Windows releases Linking only to boost_python results in one set of missing symbols, and linking only to usd_python results in another.
Member
There was a problem hiding this comment.
This would be my guess :
IECoreUSD.libdoes need to link tousd_python.so, to satisfy USD's own linking requirements. But it doesn't need to link toboost_pythonbecause our Python bindings aren't inlibIECoreUSD.so. So your patch where you replaced one library with the other depending on PXR_USE_INTERNAL_BOOST_PYTHON was right.- But
_IECoreUSD.lib(the python module) also needs to link tousd_python.so, again to satisfy USD's own linking requirements. So as well as replacing inusdEnv, we need to add inusdPythonModuleEnv.
Collaborator
Author
There was a problem hiding this comment.
This would be my guess :
Thanks! That appears to have done the trick, I've rebased this PR and updated the approach in 304f1da to link IECoreUSD to either usd_python or boost_python, and _IECoreUSD to both when necessary.
We'll be able to reinstate it at some point in the future when macOS builds of dependencies-10.x.x are available.
We take the same approach as gafferhq/gaffer to install the required SDK version as it's no longer provided by the runner.
murraystevenson
force-pushed
the
ciPlatform2024
branch
from
de8454c to
fdcc8f7
Compare
In this version, the Python bindings use Pixar's fork of Boost Python unconditionally, so we need to link to that instead.
murraystevenson
force-pushed
the
ciPlatform2024
branch
from
fdcc8f7 to
304f1da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.