Add tiff images support #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying isic-gallery with
|
| Latest commit: |
26d42b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b4102f3.isic-gallery.pages.dev |
| Branch Preview URL: | https://add-tiff-support.isic-gallery.pages.dev |
Contributor
Author
|
Hi @danlamanna and @brianhelba ! Not sure who to address this to but could you please add URI https://add-tiff-support.isic-gallery.pages.dev/ in the list of allowed redirect URIs for testing? Thank you! |
Member
|
This should be fixed now.
…On Tue, Aug 5, 2025 at 10:57 AM EkaterinaPoddubskaya ***@***.***> wrote:
EkaterinaPoddubskaya left a comment (ImageMarkup/isic-gallery#124)
Hi @danlamanna and @brianhelba ! Not sure who to address this to but could you please add URI https://add-tiff-support.isic-gallery.pages.dev/ in the list of allowed redirect URIs for testing? Thank you!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
Dan LaManna
Kitware, Inc.
|
Contributor
Author
|
Hi @danlamanna, |
Member
|
Sorry, we didn't disable it intentionally we just broke something on our end. It should be fixed (and stay that way 🤞) now. |
Checkbox supports three states: checked, unchecked, and partially checked. Previously, partially checked meant that not all matching images were displayed. Now, it reflects that the user has selected not all child options, independent of the number of displayed images. Added hasHiddenOption flag to indicate if the current option has images not associated with any of its children.
EkaterinaPoddubskaya
requested review from
brianhelba,
danlamanna and
neuroelf
danlamanna
approved these changes
Sep 2, 2025
Member
|
@neuroelf Can you review this and let us know if you accept? If so, let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #123