Ensure TemporaryFiles are always closed after use
#1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlamanna
approved these changes
Jul 2, 2025
brianhelba
force-pushed
the
unclosed-file
branch
from
81b2bcd to
d61b7a5
Compare
brianhelba
changed the title
ResourceWarning from an unclosed TemporaryFileTemporaryFiles are always closed after use
brianhelba
force-pushed
the
unclosed-file
branch
2 times, most recently
from
f7c6431 to
0fd2bb9
Compare
brianhelba
force-pushed
the
unclosed-file
branch
from
e6cd9b5 to
a0ff337
Compare
brianhelba
force-pushed
the
unclosed-file
branch
from
a0ff337 to
5e5745d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.