Add section on checking for offset table in remote blob#74
Merged
Conversation
fedorov
approved these changes
Jul 22, 2025
Member
|
Chris will review again if tag length should be checked https://dicom.nema.org/medical/dicom/current/output/chtml/part05/sect_A.4.html#table_A.4-2 |
Contributor
Author
|
@fedorov @dclunie I believe this is resolved now. Now the code:
|
Contributor
Author
Member
|
Thanks for the nudge! I added to the agenda to discuss tomorrow. |
Member
|
Chris, @dclunie did not have any questions about this. Can you add pointers to the samples that cover each of the cases so we can have it for the reference and make testing easier? |
Contributor
Author
|
@fedorov I added three examples to the snippet, one with no offset table, one with a basic offset table, and one with an extended offset table |
fedorov
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.